You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2016/06/13 04:42:59 UTC
svn commit: r1748084 - in /poi/trunk/src: java/org/apache/poi/hssf/usermodel/
ooxml/java/org/apache/poi/xssf/usermodel/ resources/devtools/
Author: onealj
Date: Mon Jun 13 04:42:59 2016
New Revision: 1748084
URL: http://svn.apache.org/viewvc?rev=1748084&view=rev
Log:
findbugs: fix URF_UNREAD_FIELD warnings
Modified:
poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFDataValidationHelper.java
poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFTextbox.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationHelper.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFGraphicFrame.java
poi/trunk/src/resources/devtools/findbugs-filters.xml
Modified: poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFDataValidationHelper.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFDataValidationHelper.java?rev=1748084&r1=1748083&r2=1748084&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFDataValidationHelper.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFDataValidationHelper.java Mon Jun 13 04:42:59 2016
@@ -27,12 +27,12 @@ import org.apache.poi.ss.util.CellRangeA
* Helper for working with Data Validation
*/
public class HSSFDataValidationHelper implements DataValidationHelper {
- @SuppressWarnings("unused")
- private HSSFSheet sheet;
+ //URF_UNREAD_FIELD
+ //private HSSFSheet sheet;
public HSSFDataValidationHelper(HSSFSheet sheet) {
super();
- this.sheet = sheet;
+ //this.sheet = sheet;
}
/*
Modified: poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFTextbox.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFTextbox.java?rev=1748084&r1=1748083&r2=1748084&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFTextbox.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFTextbox.java Mon Jun 13 04:42:59 2016
@@ -48,7 +48,8 @@ public class HSSFTextbox extends HSSFSim
super(spContainer, objRecord, textObjectRecord);
}
- HSSFRichTextString string = new HSSFRichTextString("");
+ //Unused: URF_UNREAD_FIELD
+ //HSSFRichTextString string = new HSSFRichTextString("");
/**
* Construct a new textbox with the given parent and anchor.
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationHelper.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationHelper.java?rev=1748084&r1=1748083&r2=1748084&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationHelper.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDataValidationHelper.java Mon Jun 13 04:42:59 2016
@@ -35,12 +35,13 @@ import org.openxmlformats.schemas.spread
*
*/
public class XSSFDataValidationHelper implements DataValidationHelper {
- private XSSFSheet xssfSheet;
+ //Unused: URF_UNREAD_FIELD
+ //private XSSFSheet xssfSheet;
public XSSFDataValidationHelper(XSSFSheet xssfSheet) {
super();
- this.xssfSheet = xssfSheet;
+ //this.xssfSheet = xssfSheet;
}
/* (non-Javadoc)
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFGraphicFrame.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFGraphicFrame.java?rev=1748084&r1=1748083&r2=1748084&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFGraphicFrame.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFGraphicFrame.java Mon Jun 13 04:42:59 2016
@@ -43,7 +43,8 @@ public final class XSSFGraphicFrame exte
private static CTGraphicalObjectFrame prototype = null;
private CTGraphicalObjectFrame graphicFrame;
- private XSSFDrawing drawing;
+ // Unused: URF_UNREAD_FIELD
+ //private XSSFDrawing drawing;
private XSSFClientAnchor anchor;
/**
Modified: poi/trunk/src/resources/devtools/findbugs-filters.xml
URL: http://svn.apache.org/viewvc/poi/trunk/src/resources/devtools/findbugs-filters.xml?rev=1748084&r1=1748083&r2=1748084&view=diff
==============================================================================
--- poi/trunk/src/resources/devtools/findbugs-filters.xml (original)
+++ poi/trunk/src/resources/devtools/findbugs-filters.xml Mon Jun 13 04:42:59 2016
@@ -47,18 +47,31 @@
</Or>
<Bug code="Nm" />
</Match>
+
+ <!-- ignore fields that correspond to the values in a H??F binary record -->
+ <Match>
+ <Class name="~org\.apache\.poi\.h..f\..*"/>
+ <Bug pattern="URF_UNREAD_FIELD" />
+ <Field name="~field_[12345].*" />
+ </Match>
<Match>
- <Class name="org.apache.poi.hpsf.Decimal"/>
+ <Class name="org.apache.poi.hssf.usermodel.HSSFChart"/>
<Bug pattern="URF_UNREAD_FIELD" />
- <Field name="field_[12345]_.+" />
+ <Field name="chartTitleFormat" />
</Match>
+ <Match>
+ <Class name="org.apache.poi.hwmf.record.HwmfWindowing"/>
+ <Bug pattern="URF_UNREAD_FIELD" />
+ <Field name="count2" />
+ </Match>
+
+
<!-- invalid performance issues - e.g. see #57840 -->
<Match>
- <Class name="org.apache.poi.xssf.usermodel.XSSFRow"/>
- <Bug pattern="DM_NUMBER_CTOR" />
- </Match>
- <Match>
- <Class name="org.apache.poi.xssf.usermodel.XSSFSheet"/>
+ <Or>
+ <Class name="org.apache.poi.xssf.usermodel.XSSFRow"/>
+ <Class name="org.apache.poi.xssf.usermodel.XSSFSheet"/>
+ </Or>
<Bug pattern="DM_NUMBER_CTOR" />
</Match>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org