You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/04 16:42:00 UTC
[jira] [Commented] (MINIFICPP-448) Allow uuid to be built &
statically-linked
[ https://issues.apache.org/jira/browse/MINIFICPP-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425827#comment-16425827 ]
ASF GitHub Bot commented on MINIFICPP-448:
------------------------------------------
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/294
MINIFICPP-448 Add uuid external/static link project
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-448
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/294.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #294
----
commit 1f1e8f5421a9394464e67d2891fb19fb1c6dd5e9
Author: Andrew I. Christianson <an...@...>
Date: 2018-04-04T16:41:07Z
MINIFICPP-448 Add uuid external/static link project
----
> Allow uuid to be built & statically-linked
> ------------------------------------------
>
> Key: MINIFICPP-448
> URL: https://issues.apache.org/jira/browse/MINIFICPP-448
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Andrew Christianson
> Assignee: Andrew Christianson
> Priority: Major
>
> We already bundle uuid code in nifi-minifi-cpp, but there is no way to build it. The CMakeLists.txt should be updated to allow building of this bundled uuid and statically-linking it, making it easier to run in environments where uuid is not available.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)