You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/05/14 13:53:06 UTC
[GitHub] [dubbo-go] luyi404 opened a new pull request, #1890: Fix: Interface conversion when parsing Hystrix filter config in yaml file (#1883)
luyi404 opened a new pull request, #1890:
URL: https://github.com/apache/dubbo-go/pull/1890
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
I tested the problem mentioned in [#1883](https://github.com/apache/dubbo-go/issues/1883). When I trying to set hystrix in config file, I get the type conversion problem, even though I have used it as example in the source code(https://github.com/apache/dubbo-go/blob/master/filter/hystrix/filter.go#L86-L126).
**What this PR does**:
- Add a type check to fix interface conversion error when parsing Hystrix filter config in yaml file.
**Which issue(s) this PR fixes**:
Fixes #1883
**You should pay attention to items below to ensure your pr passes our ci test**
We do not merge pr with ci tests failed
- [ ] All ut passed (run 'go test ./...' in project root)
- [ ] After go-fmt ed , run 'go fmt project' using goland.
- [ ] Golangci-lint passed, run 'sudo golangci-lint run' in project root.
- [ ] After import formatted, (using [imports-formatter](https://github.com/dubbogo/tools#5-how-to-get-imports-formatter) to run 'imports-formatter .' in project root, to format your import blocks, mentioned in [CONTRIBUTING.md](https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md) above)
- [ ] Your new-created file needs to have [apache license](https://raw.githubusercontent.com/dubbogo/resources/master/tools/license/license.txt) at the top, like other existed file does.
- [ ] All integration test passed. You can run integration test locally (with docker env). Clone our [dubbo-go-samples](https://github.com/apache/dubbo-go-samples) project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] luyi404 commented on pull request #1890: Fix: Interface conversion when parsing Hystrix filter config in yaml file (#1883)
Posted by GitBox <gi...@apache.org>.
luyi404 commented on PR #1890:
URL: https://github.com/apache/dubbo-go/pull/1890#issuecomment-1126721271
> Please create pr to 3.0 branch.
Ok, I'll create a new pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sheny1xuan commented on pull request #1890: Fix: Interface conversion when parsing Hystrix filter config in yaml file (#1883)
Posted by GitBox <gi...@apache.org>.
sheny1xuan commented on PR #1890:
URL: https://github.com/apache/dubbo-go/pull/1890#issuecomment-1126721043
Please create pr to 3.0 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] luyi404 closed pull request #1890: Fix: Interface conversion when parsing Hystrix filter config in yaml file (#1883)
Posted by GitBox <gi...@apache.org>.
luyi404 closed pull request #1890: Fix: Interface conversion when parsing Hystrix filter config in yaml file (#1883)
URL: https://github.com/apache/dubbo-go/pull/1890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org