You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/10/27 15:48:09 UTC

[GitHub] [kafka] cmccabe commented on pull request #11385: KAFKA-13385: In the KRPC request header, translate null clientID to empty

cmccabe commented on pull request #11385:
URL: https://github.com/apache/kafka/pull/11385#issuecomment-953060832


   > Good catch. Could we add a test to avoid this regression in the future?
   
   Yes, absolutely. I actually posted this only to try to find out which junit test would fail when I changed the null handling. Unfortunately, it seems like none of them did! (Or rather, the only test failures I see in this run are unrelated test flakes.)
   
   I'll add a unit test for this case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org