You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/04/02 05:57:00 UTC

[jira] [Work logged] (GOBBLIN-1105) make MysqlJobStatusStateStore implements DatasetStateStore

     [ https://issues.apache.org/jira/browse/GOBBLIN-1105?focusedWorklogId=414484&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414484 ]

ASF GitHub Bot logged work on GOBBLIN-1105:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Apr/20 05:56
            Start Date: 02/Apr/20 05:56
    Worklog Time Spent: 10m 
      Work Description: sv2000 commented on pull request #2945: [GOBBLIN-1105] some refactoring and make MysqlJobStatusStateStore implements DatasetStateStore
URL: https://github.com/apache/incubator-gobblin/pull/2945#discussion_r402067225
 
 

 ##########
 File path: gobblin-metastore/src/main/java/org/apache/gobblin/metastore/MysqlStateStore.java
 ##########
 @@ -73,7 +74,7 @@
  *
  * @param <T> state object type
  **/
-public class MysqlStateStore<T extends State> implements StateStore<T> {
+public class MysqlStateStore<T extends State> implements StateStore<T>, DatasetStateStore<T> {
 
 Review comment:
   Instead of changing MySqlStateStore (and indeed, other state store implementations), can we have MySqlJobStatusStateStore implement DatasetStateStore interface? Won't that change be more localized?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 414484)
    Time Spent: 1h 20m  (was: 1h 10m)

> make MysqlJobStatusStateStore implements DatasetStateStore
> ----------------------------------------------------------
>
>                 Key: GOBBLIN-1105
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1105
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> make MysqlJobStatusStateStore implements DatasetStateStore so that we can use existing cleaners/dataset finders/version finders to clean job status



--
This message was sent by Atlassian Jira
(v8.3.4#803005)