You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Lutz Dornbusch <sv...@yogasurftech.de> on 2008/06/30 13:05:44 UTC
dump / verify stumbles over double slashes "//"?
Hello
I recently coded a small java application based on svnkit which performs
some copyactions (directly on server via file://)inside a single
transaction: eg.
folder_1/file_a -> folder_100/file_a
folder_1/file_b -> folder_100/file_b
folder_2/file_c -> folder_101/file_c
I had a small bug in my program which adds an additional slash "/" to
each folder, so the above mentioned sample reads:
folder_1//file_a -> folder_100//file_a
folder_1//file_b -> folder_100//file_b
folder_2//file_c -> folder_101//file_c
However, the commit runs fine and I was also able to update a
workingcopy, so I didn't bother about this double slash. But if I try to
verify my repository or dump its contents I run into terrible problems:
The Revision I produced by my java app breaks the repository. Verify and
dump will both stop on the same revision with this message:
Assertion failed: is_canonical(component, clen), file
C:\Projects\subversion-1.4
.6\subversion\libsvn_subr\path.c, line 115
I think this a bug of svn, as it really should not allow to commit
"non-canonical paths" if it is not able to handle them. By using a
customized client (my java app, in this case) I am able to destroy a
repository so it can not be verified anymore or be backuped, but you can
still work with this repository.
Should I file an issue? can somebody confirm this behaviour?
I am using svn 1.4.6
Thanx for your time,
Lutz Dornbusch
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: dump / verify stumbles over double slashes "//"?
Posted by Mark Phippard <ma...@gmail.com>.
On Mon, Jun 30, 2008 at 9:05 AM, Lutz Dornbusch <sv...@yogasurftech.de> wrote:
> Hello
> I recently coded a small java application based on svnkit which performs
> some copyactions (directly on server via file://)inside a single
> transaction: eg.
> folder_1/file_a -> folder_100/file_a
> folder_1/file_b -> folder_100/file_b
> folder_2/file_c -> folder_101/file_c
>
> I had a small bug in my program which adds an additional slash "/" to each
> folder, so the above mentioned sample reads:
> folder_1//file_a -> folder_100//file_a
> folder_1//file_b -> folder_100//file_b
> folder_2//file_c -> folder_101//file_c
>
> However, the commit runs fine and I was also able to update a workingcopy,
> so I didn't bother about this double slash. But if I try to verify my
> repository or dump its contents I run into terrible problems:
> The Revision I produced by my java app breaks the repository. Verify and
> dump will both stop on the same revision with this message:
>
> Assertion failed: is_canonical(component, clen), file
> C:\Projects\subversion-1.4
> .6\subversion\libsvn_subr\path.c, line 115
>
> I think this a bug of svn, as it really should not allow to commit
> "non-canonical paths" if it is not able to handle them. By using a
> customized client (my java app, in this case) I am able to destroy a
> repository so it can not be verified anymore or be backuped, but you can
> still work with this repository.
>
> Should I file an issue? can somebody confirm this behaviour?
>
> I am using svn 1.4.6
Did SVNKit use file:// or go through a server? If it was the former,
then what could Subversion do about it? SVNKit write the repository
itself.
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: dump / verify stumbles over double slashes "//"?
Posted by Daniel Shahaf <d....@daniel.shahaf.co.il>.
Marc Haisenko wrote on Tue, 1 Jul 2008 at 16:24 +0200:
> As you wrote, the bug is not in SubVersion but SVNKit,
^
s/SubVersion/Subversion/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: dump / verify stumbles over double slashes "//"?
Posted by Marc Haisenko <ha...@comdasys.com>.
On Monday 30 June 2008, Lutz Dornbusch wrote:
> Hello
> I recently coded a small java application based on svnkit which performs
> some copyactions (directly on server via file://)inside a single
> transaction:
> [...]
> I had a small bug in my program which adds an additional slash "/" to
> each folder, so the above mentioned sample reads:
> [...]
> I think this a bug of svn, as it really should not allow to commit
> "non-canonical paths" if it is not able to handle them. By using a
> customized client (my java app, in this case) I am able to destroy a
> repository so it can not be verified anymore or be backuped, but you can
> still work with this repository.
As you wrote, the bug is not in SubVersion but SVNKit, which is independent of
SubVersion (it doesn't use the SubVersion libraries). So you need to file a
bug report there. SubVersion is not part of this operation and thus can't do
a thing, because this is a third-party library manipulating the repository
(think of it like if you were messing around in the repository with an
editor: SubVersion can't prevent that; of course I don't mean to insult
SVNKit here, bugs just happen :-))
Marc
--
Marc Haisenko
Comdasys AG
Rüdesheimer Str. 7
80686 München
Germany
Tel.: +49 (0)89 548 433 321
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org