You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "codope (via GitHub)" <gi...@apache.org> on 2023/03/06 15:50:34 UTC
[GitHub] [hudi] codope opened a new pull request, #8105: Handle pending clean instants while running savepoint
codope opened a new pull request, #8105:
URL: https://github.com/apache/hudi/pull/8105
### Change Logs
Currently, savepoint only considers the completed clean instant. It is possible just before savepoint started, a clean instant was inflight. Savepoint completed as well as clean complated. But, now when we do restore to that savepoint, it will fail as the cleaner would have cleaned up the instant. This PR fixes that by aborting savepoint if there is a pending clean with earliest commit to retain greater than savepoint instant.
### Impact
No public API change. Fixing a corner case in savepoint.
### Risk level (write none, low medium or high below)
low
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan merged pull request #8105: [HUDI-5881] Handle pending clean instants while running savepoint
Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan merged PR #8105:
URL: https://github.com/apache/hudi/pull/8105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8105: Handle pending clean instants while running savepoint
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8105:
URL: https://github.com/apache/hudi/pull/8105#issuecomment-1456680220
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "25f603d553a1139b8c98aec5c06291900ef89554",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15595",
"triggerID" : "25f603d553a1139b8c98aec5c06291900ef89554",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 25f603d553a1139b8c98aec5c06291900ef89554 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15595)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8105: Handle pending clean instants while running savepoint
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8105:
URL: https://github.com/apache/hudi/pull/8105#issuecomment-1456420523
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "25f603d553a1139b8c98aec5c06291900ef89554",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15595",
"triggerID" : "25f603d553a1139b8c98aec5c06291900ef89554",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 25f603d553a1139b8c98aec5c06291900ef89554 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15595)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8105: Handle pending clean instants while running savepoint
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8105:
URL: https://github.com/apache/hudi/pull/8105#issuecomment-1456407204
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "25f603d553a1139b8c98aec5c06291900ef89554",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "25f603d553a1139b8c98aec5c06291900ef89554",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 25f603d553a1139b8c98aec5c06291900ef89554 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org