You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/04/09 19:30:33 UTC

[GitHub] [druid] mcbrewster opened a new pull request #9653: fix dimension spec in sampler

mcbrewster opened a new pull request #9653: fix dimension spec in sampler
URL: https://github.com/apache/druid/pull/9653
 
 
   In sampler.ts sampleForConnect, sampleForFilter and sampleForTransform never check if there is a dimensionSpec on the spec that is passed in as an argument. This causes dimensionsSpec to be set as {} on the sample which prevents the reindex flow from detecting columns with edited names or created using transforms. 
   
   This will also prevent transformed columns from disappearing in the filter and configure steps. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org