You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/24 12:07:27 UTC
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5504: Fix permission issue during Diagnostic service garbage collection
sureshanaparti commented on a change in pull request #5504:
URL: https://github.com/apache/cloudstack/pull/5504#discussion_r715556173
##########
File path: server/src/main/java/org/apache/cloudstack/diagnostics/DiagnosticsServiceImpl.java
##########
@@ -481,17 +478,11 @@ public Long getDelay() {
private void cleanupOldDiagnosticFiles(DataStore store) {
String mountPoint = null;
- try {
- mountPoint = serviceImpl.mountManager.getMountPoint(store.getUri(), null);
- if (StringUtils.isNotBlank(mountPoint)) {
- File directory = new File(mountPoint + File.separator + DIAGNOSTICS_DIRECTORY);
- if (directory.isDirectory()) {
- deleteOldDiagnosticsFiles(directory, store.getName());
- }
- }
- } finally {
- if (StringUtils.isNotBlank(mountPoint)) {
- umountSecondaryStorage(mountPoint);
+ mountPoint = serviceImpl.mountManager.getMountPoint(store.getUri(), null);
+ if (StringUtils.isNotBlank(mountPoint)) {
+ File directory = new File(mountPoint + File.separator + DIAGNOSTICS_DIRECTORY);
+ if (directory.isDirectory()) {
+ deleteOldDiagnosticsFiles(directory, store.getName());
Review comment:
Does the secondary storage stay mounted on hypervisors other than VMware, after cleanup of diagnostics files? If so, it is better to fix the permission issue (on VMware), and unmount the secondary storage from mgmt server when not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org