You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Oliver Klozoff <st...@fastmail.fm> on 2004/12/14 14:34:10 UTC

[PATCH] svnlook --revprop patch, take three

[Julian: Thank you for your patience and guidance :)]

This patch adds --revprop support to svnlook propget and svnlook proplist.
It also adds more basic regression tests for other svnlook subcommands.

-- Stevie-O
Real programmers use COPY CON PROGRAM.EXE

--- log message follows ---

* subversion/svnlook/main.c
    (subcommand_plist, subcommand_pget):
      Pass NULL for the path argument to do_plist/do_pget
      when --revprop is specified.

    (do_plist, do_pget):
       When the 'path' argument is NULL, switch from svn_fs_node_proplist/
       svn_fs_node_prop to svn_fs_revision_proplist/svn_fs_revision_prop.

* subversion/tests/clients/cmdline/svnlook_tests.py
     (test_propget_revprop): New. Tests 'svnlook propget --revprop'.
     (test_propget_revprop_missing): New. 'Tests svnlook --revprop'
       for a revision property that doesn't exist.
     (test_proplist_revprop): New. Tests 'svnlook proplist --revprop'.
     (test_uuid): New. Tests 'svnlook uuid'.
     (test_logmsg): New. Tests 'svnlook log'.
     (test_author): New. Tests 'svnlook author'.
     (test_list): Added the new tests.

* subversion/tests/clients/cmdline/svntest/main.py
     (run_command_stdin) New. Just like 'run_command',
     except it allows the caller to specify data to be piped into
     the command's stdin (needed by 'test_uuid').

Re: [PATCH] svnlook --revprop patch, take three

Posted by Michael W Thelen <mi...@pietdepsi.com>.
Oliver Klozoff wrote:
> [Julian: Thank you for your patience and guidance :)]
> 
> This patch adds --revprop support to svnlook propget and svnlook proplist.
> It also adds more basic regression tests for other svnlook subcommands.

Thanks for the patch.  Since there didn't seem to be consensus about 
whether to apply it, I went ahead and filed this patch as issue #2181:
http://subversion.tigris.org/issues/show_bug.cgi?id=2181

-- 
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams