[GitHub] [flink] PatrickRen commented on a diff in pull request #20884: [FLINK-29389][docs] Update documentation of JDBC and HBase lookup table for new caching options

[GitBox <gi...@apache.org>]

PatrickRen commented on code in PR #20884:
URL: https://github.com/apache/flink/pull/20884#discussion_r978232542


##########
docs/content/docs/connectors/table/jdbc.md:
##########
@@ -211,30 +211,48 @@ Connector Options
       <a href="https://jdbc.postgresql.org/documentation/head/query.html#query-with-cursor">Postgres</a>, may require this to be set to false in order to stream results.</td>
     </tr>
     <tr>
-      <td><h5>lookup.cache.max-rows</h5></td>
+      <td><h5>lookup.cache</h5></td>
+      <td>optional</td>
+      <td>yes</td>
+      <td style="word-wrap: break-word;">NONE</td>
+      <td><p>Enum</p>Possible values: NONE, PARTIAL</td>

Review Comment:
   I'm afraid this could confuse users that we list an unavailable option in the doc, which increases the cost of explanation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org