You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/12/15 21:41:03 UTC
[GitHub] [tvm] nverke commented on a diff in pull request #13613: Add check for non-contiguous memory access when lowering to async dma…
nverke commented on code in PR #13613:
URL: https://github.com/apache/tvm/pull/13613#discussion_r1050165016
##########
src/tir/transforms/lower_async_dma.cc:
##########
@@ -146,13 +153,32 @@ class AsyncDMALowerer : public StmtExprMutator {
// map loop variable to zero for the store index & simplify
Array<PrimExpr> store_index = bufferstorenode->indices;
+
+ // Use DetectIterMap to detect whether store index is non-contiguous.
+ arith::Analyzer analyzer;
+ auto store_iter_map = DetectIterMap(store_index, input_iters, 1, arith::IterMapLevel::NoCheck,
+ &analyzer, false);
+ if (!store_iter_map->errors.empty()) {
+ LOG(FATAL) << "Unable to lower async dma for non contiguous memory access with index: "
Review Comment:
Added!
##########
src/tir/transforms/lower_async_dma.cc:
##########
@@ -146,13 +153,32 @@ class AsyncDMALowerer : public StmtExprMutator {
// map loop variable to zero for the store index & simplify
Array<PrimExpr> store_index = bufferstorenode->indices;
+
+ // Use DetectIterMap to detect whether store index is non-contiguous.
+ arith::Analyzer analyzer;
+ auto store_iter_map = DetectIterMap(store_index, input_iters, 1, arith::IterMapLevel::NoCheck,
+ &analyzer, false);
+ if (!store_iter_map->errors.empty()) {
+ LOG(FATAL) << "Unable to lower async dma for non contiguous memory access with index: "
+ << store_index;
+ }
+
store_index.MutateByApply([&](PrimExpr expr) {
arith::Analyzer analyzer;
return analyzer.Simplify(Substitute(std::move(expr), loop_var_remap));
});
// map loop variable to zero for the load index & simplify
Array<PrimExpr> load_index = bufferloadnode->indices;
+
+ // Use DetectIterMap to detect whether load index is non-contiguous.
+ auto load_iter_map =
+ DetectIterMap(load_index, input_iters, 1, arith::IterMapLevel::NoCheck, &analyzer, false);
+ if (!load_iter_map->errors.empty()) {
+ LOG(FATAL) << "Unable to lower async dma for non contiguous memory access with index: "
Review Comment:
Added!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org