You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/12/23 11:06:08 UTC

[GitHub] [submarine] FatalLin opened a new pull request #848: SUBMARINE-1139. add internal api for status sync

FatalLin opened a new pull request #848:
URL: https://github.com/apache/submarine/pull/848


   ### What is this PR for?
   I added an internal service in submarine-server which allow the agent which is appended on our custom resource object to sync their tracking result to database, also push the status change via web-socket.
   
   ### What type of PR is it?
   Feature
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-1139
   ### How should this be tested?
   the unit test should be added later.
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] FatalLin commented on a change in pull request #848: SUBMARINE-1139. add internal api for status sync

Posted by GitBox <gi...@apache.org>.
FatalLin commented on a change in pull request #848:
URL: https://github.com/apache/submarine/pull/848#discussion_r775685276



##########
File path: submarine-server/server-api/src/main/java/org/apache/submarine/server/api/Submitter.java
##########
@@ -44,10 +44,11 @@
   /**
    * Create experiment with spec
    * @param spec experiment spec
+   * @param id experimentId 
    * @return object
    * @throws SubmarineRuntimeException running error
    */
-  Experiment createExperiment(ExperimentSpec spec) throws SubmarineRuntimeException;
+  Experiment createExperiment(ExperimentSpec spec, String experimentId) throws SubmarineRuntimeException;

Review comment:
       oh i haven't notice before, will recover it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] pingsutw commented on a change in pull request #848: SUBMARINE-1139. add internal api for status sync

Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #848:
URL: https://github.com/apache/submarine/pull/848#discussion_r775621495



##########
File path: submarine-server/server-api/src/main/java/org/apache/submarine/server/api/Submitter.java
##########
@@ -44,10 +44,11 @@
   /**
    * Create experiment with spec
    * @param spec experiment spec
+   * @param id experimentId 
    * @return object
    * @throws SubmarineRuntimeException running error
    */
-  Experiment createExperiment(ExperimentSpec spec) throws SubmarineRuntimeException;
+  Experiment createExperiment(ExperimentSpec spec, String experimentId) throws SubmarineRuntimeException;

Review comment:
       We already have `experimentId` in `ExperimentSpec`. 
   Check `ExperimentSpec` -> `ExperimentMeta` -> `experimentId`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] FatalLin commented on a change in pull request #848: SUBMARINE-1139. add internal api for status sync

Posted by GitBox <gi...@apache.org>.
FatalLin commented on a change in pull request #848:
URL: https://github.com/apache/submarine/pull/848#discussion_r775692131



##########
File path: submarine-server/server-api/src/main/java/org/apache/submarine/server/api/Submitter.java
##########
@@ -44,10 +44,11 @@
   /**
    * Create experiment with spec
    * @param spec experiment spec
+   * @param id experimentId 
    * @return object
    * @throws SubmarineRuntimeException running error
    */
-  Experiment createExperiment(ExperimentSpec spec) throws SubmarineRuntimeException;
+  Experiment createExperiment(ExperimentSpec spec, String experimentId) throws SubmarineRuntimeException;

Review comment:
       the code has been rollback.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #848: SUBMARINE-1139. add internal api for status sync

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #848:
URL: https://github.com/apache/submarine/pull/848


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org