You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by vi...@apache.org on 2016/04/12 21:23:36 UTC

[3/5] mesos git commit: Cleaned up the virtual overloads in long lived framework.

Cleaned up the virtual overloads in long lived framework.

This change removes the unused methods that won't be needed
after moving to the v1 API. This review mainly eases reviewing
later in the chain and should not be committed on its own.

Review: https://reviews.apache.org/r/45799/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/a5b0cbee
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/a5b0cbee
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/a5b0cbee

Branch: refs/heads/master
Commit: a5b0cbee860dfdb5bc5b5355d11b66d0f765357a
Parents: c82c12a
Author: Anand Mazumdar <ma...@gmail.com>
Authored: Tue Apr 12 12:23:17 2016 -0700
Committer: Vinod Kone <vi...@gmail.com>
Committed: Tue Apr 12 12:23:17 2016 -0700

----------------------------------------------------------------------
 src/examples/long_lived_framework.cpp | 33 ------------------------------
 1 file changed, 33 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/a5b0cbee/src/examples/long_lived_framework.cpp
----------------------------------------------------------------------
diff --git a/src/examples/long_lived_framework.cpp b/src/examples/long_lived_framework.cpp
index 035ddda..7d8a5c3 100644
--- a/src/examples/long_lived_framework.cpp
+++ b/src/examples/long_lived_framework.cpp
@@ -93,29 +93,6 @@ public:
     process::wait(metrics);
   }
 
-  virtual void registered(SchedulerDriver*,
-                          const FrameworkID&,
-                          const MasterInfo&)
-  {
-    LOG(INFO) << "Registered!";
-
-    metrics.isRegistered = true;
-  }
-
-  virtual void reregistered(SchedulerDriver*, const MasterInfo& masterInfo)
-  {
-    LOG(INFO) << "Re-registered!";
-
-    metrics.isRegistered = true;
-  }
-
-  virtual void disconnected(SchedulerDriver* driver)
-  {
-    LOG(INFO) << "Disconnected!";
-
-    metrics.isRegistered = false;
-  }
-
   virtual void resourceOffers(SchedulerDriver* driver,
                               const vector<Offer>& offers)
   {
@@ -160,9 +137,6 @@ public:
     }
   }
 
-  virtual void offerRescinded(SchedulerDriver* driver,
-                              const OfferID& offerId) {}
-
   virtual void statusUpdate(SchedulerDriver* driver, const TaskStatus& status)
   {
     LOG(INFO)
@@ -178,11 +152,6 @@ public:
     }
   }
 
-  virtual void frameworkMessage(SchedulerDriver* driver,
-                                const ExecutorID& executorId,
-                                const SlaveID& slaveId,
-                                const string& data) {}
-
   virtual void slaveLost(SchedulerDriver* driver, const SlaveID& _slaveId)
   {
     LOG(INFO) << "Slave lost: " << _slaveId;
@@ -204,8 +173,6 @@ public:
     slaveId = None();
   }
 
-  virtual void error(SchedulerDriver* driver, const string& message) {}
-
 private:
   // Helper to decline an offer.
   void declineOffer(SchedulerDriver* driver, const Offer& offer)