[jira] Closed: (GERONIMO-4766) JACC handler data is not implemented properly

["David Jencks (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GERONIMO-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Jencks closed GERONIMO-4766.
----------------------------------

    Resolution: Fixed

Implemented rev 798211.

> JACC handler data is not implemented properly
> ---------------------------------------------
>
>                 Key: GERONIMO-4766
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4766
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: security
>    Affects Versions: 2.2
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 2.2
>
>
> After looking at GERONIMO-2622 I studied the jacc spec and realized we didn't implement the handler data stuff properly.
> The PolicyContextHandlers are supposed to be getting their information out of the container.  The Object supplied to PolicyContext.setHandlerData is not supposed to be the httpServletRequest, SOAPMessage, ejb bean, or ejb args, or Subject, but rather  a container specific optional helper object that can work with the PolicyContextHandlers.  My implementation has a ThreadData object with slots for the different kinds of data: this is kept in a threadLocal in ContextManager and also supplied when created to the PolicyContext.setHandlerData.  Each PolicyContextHandler has static methods to push and pop its appropriate data in the ThreadData object.  The PolicyContextHandler getData method fishes the info out of the appropriate slot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.