You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "elichai (via GitHub)" <gi...@apache.org> on 2024/12/15 16:43:18 UTC
[I] new feature: Memcached In Transit Encryption (TLS) support [opendal]
elichai opened a new issue, #5419:
URL: https://github.com/apache/opendal/issues/5419
### Feature Description
AWS Elasticache Memcached serverless instances require using TLS,
meaning that instead of doing `telnet ....cache.amazonaws.com 1211` you do `openssl s_client -quiet -crlf -connect ....cache.amazonaws.com:11211`, supporting this TLS mode here would be great :)
### Problem and Solution
Adding TLS support, See: https://docs.aws.amazon.com/AmazonElastiCache/latest/dg/in-transit-encryption.html
### Additional Context
_No response_
### Are you willing to contribute to the development of this feature?
- [ ] Yes, I am willing to contribute to the development of this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] new feature: Memcached In Transit Encryption (TLS) support [opendal]
Posted by "ozewr (via GitHub)" <gi...@apache.org>.
ozewr commented on issue #5419:
URL: https://github.com/apache/opendal/issues/5419#issuecomment-2552897583
Hello, I would like to contribute to the development of this feature. Could you tell me which part of the code I should read , or provide some other relevant information? @Xuanwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] new feature: Memcached In Transit Encryption (TLS) support [opendal]
Posted by "geetanshjuneja (via GitHub)" <gi...@apache.org>.
geetanshjuneja commented on issue #5419:
URL: https://github.com/apache/opendal/issues/5419#issuecomment-2562674274
@Xuanwo I wanna take up this task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] new feature: Memcached In Transit Encryption (TLS) support [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #5419:
URL: https://github.com/apache/opendal/issues/5419#issuecomment-2562883264
> @Xuanwo I wanna take up this task.
Hi, @ozewr is working on this now. Maybe we can collaborate with them first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] new feature: Memcached In Transit Encryption (TLS) support [opendal]
Posted by "ozewr (via GitHub)" <gi...@apache.org>.
ozewr commented on issue #5419:
URL: https://github.com/apache/opendal/issues/5419#issuecomment-2556628543
> Hi, @ozewr, thank you for your interest!
>
> Memcached currently interacts directly with `TcpStream`:
>
> https://github.com/apache/opendal/blob/f0ace5640c310e5dec3b3d368346442bdc1b7a1d/core/src/services/memcached/binary.rs#L104-L109
>
> We need to add support for using a TLS library like `tokio_rustls` to establish a TLS connection. For example: https://github.com/rustls/tokio-rustls/blob/main/examples/client.rs
Hello, I'm a new programmer, so I want to share my thoughts and see if they are correct. It seems that here we need a new struct implementing [bb8::ManageConnection](https://docs.rs/bb8/latest/bb8/trait.ManageConnection.html), similar to [MemcacheConnectionManager](https://github.com/apache/opendal/blob/7f0c9a14d168e7796200a77db3328b2dd7acf83a/core/src/services/memcached/backend.rs#L245). However,
```Rust
impl bb8::ManageConnection for MemcacheConnectionManager {
type Connection = TlsConnection { io: BufReader<TlsStream<TcpStream>> };
type Error = Error;
...
```
Or directly modify the implementation of [bb8::ManageConnection](https://docs.rs/bb8/latest/bb8/trait.ManageConnection.html) for [MemcacheConnectionManager](https://github.com/apache/opendal/blob/7f0c9a14d168e7796200a77db3328b2dd7acf83a/core/src/services/memcached/backend.rs#L245) to make it only support TLS connections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] new feature: Memcached In Transit Encryption (TLS) support [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #5419:
URL: https://github.com/apache/opendal/issues/5419#issuecomment-2557160949
Maybe we can make `binary::Connection` an enum that have `TcpConnection` and `TlsConnection`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] new feature: Memcached In Transit Encryption (TLS) support [opendal]
Posted by "ozewr (via GitHub)" <gi...@apache.org>.
ozewr commented on issue #5419:
URL: https://github.com/apache/opendal/issues/5419#issuecomment-2562903389
> > @Xuanwo I wanna take up this task.
>
> Hi, @ozewr is working on this now. Maybe we can collaborate with them first?
Sorry, I’ve been a bit busy with my day job this week, but I think I should be able to submit a PR tomorrow. I think we can collaborate on it. @geetanshjuneja
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] new feature: Memcached In Transit Encryption (TLS) support [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #5419:
URL: https://github.com/apache/opendal/issues/5419#issuecomment-2553189661
Hi, @ozewr, thank you for your interest!
Memcached currently interacts directly with `TcpStream`: https://github.com/apache/opendal/blob/f0ace5640c310e5dec3b3d368346442bdc1b7a1d/core/src/services/memcached/binary.rs#L104-L109
We need to add support for using a TLS library like `tokio_rustls` to establish a TLS connection. For example: https://github.com/rustls/tokio-rustls/blob/main/examples/client.rs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] new feature: Memcached In Transit Encryption (TLS) support [opendal]
Posted by "rishis123 (via GitHub)" <gi...@apache.org>.
rishis123 commented on issue #5419:
URL: https://github.com/apache/opendal/issues/5419#issuecomment-4666308451
Hi! I'm a student in the CodePath AI301 program and I'd like to work on this issue. It looks like changes haven't been made to #5471 in a while, so I'll start by reproducing the problem locally this week. Any pointers on where to start in the codebase would be appreciated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org