You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/08/21 21:40:23 UTC

[GitHub] [maven-release] nielsbasjes commented on pull request #145: Simplify PerformReleaseMojo

nielsbasjes commented on PR #145:
URL: https://github.com/apache/maven-release/pull/145#issuecomment-1221625797

   I had a look at this code and I agree that there is indeed some duplication that can be simplified this way.
   As the entire build pipeline passes I think the code change is good.
   The only "effect" is that you reduce the code duplication (good) and the PerformReleaseMojo will have more config settings available than needed.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org