You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/18 10:50:09 UTC

[GitHub] [skywalking-cli] kezhenxu94 opened a new pull request #82: chore: reorganize the project layout and add an example of .skywalking.yaml

kezhenxu94 opened a new pull request #82:
URL: https://github.com/apache/skywalking-cli/pull/82


   This patch reshapes the project layout by following https://github.com/golang-standards/project-layout/ , to prepare for our NGE2E project, this may need a little changes in the `swck` @hanahmily because the schema is moved to `/api`, which I think is more suitable.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] codecov-io commented on pull request #82: chore: reorganize the project layout and add an example of .skywalking.yaml

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #82:
URL: https://github.com/apache/skywalking-cli/pull/82#issuecomment-748101243


   # [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/82?src=pr&el=h1) Report
   > Merging [#82](https://codecov.io/gh/apache/skywalking-cli/pull/82?src=pr&el=desc) (72d9b2e) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/68ca77c73eafc63a13178165d9d2ef4720b902e5?el=desc) (68ca77c) will **not change** coverage.
   > The diff coverage is `80.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking-cli/pull/82/graphs/tree.svg?width=650&height=150&src=pr&token=oivudZDTNJ)](https://codecov.io/gh/apache/skywalking-cli/pull/82?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master      #82   +/-   ##
   =======================================
     Coverage   44.89%   44.89%           
   =======================================
     Files           9        9           
     Lines         147      147           
   =======================================
     Hits           66       66           
     Misses         73       73           
     Partials        8        8           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking-cli/pull/82?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [internal/commands/interceptor/interceptor.go](https://codecov.io/gh/apache/skywalking-cli/pull/82/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY29tbWFuZHMvaW50ZXJjZXB0b3IvaW50ZXJjZXB0b3IuZ28=) | `0.00% <ø> (ø)` | |
   | [internal/commands/interceptor/timezone.go](https://codecov.io/gh/apache/skywalking-cli/pull/82/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY29tbWFuZHMvaW50ZXJjZXB0b3IvdGltZXpvbmUuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/display/json/json.go](https://codecov.io/gh/apache/skywalking-cli/pull/82/diff?src=pr&el=tree#diff-cGtnL2Rpc3BsYXkvanNvbi9qc29uLmdv) | `60.00% <ø> (ø)` | |
   | [pkg/display/table/table.go](https://codecov.io/gh/apache/skywalking-cli/pull/82/diff?src=pr&el=tree#diff-cGtnL2Rpc3BsYXkvdGFibGUvdGFibGUuZ28=) | `100.00% <ø> (ø)` | |
   | [pkg/display/yaml/yaml.go](https://codecov.io/gh/apache/skywalking-cli/pull/82/diff?src=pr&el=tree#diff-cGtnL2Rpc3BsYXkveWFtbC95YW1sLmdv) | `60.00% <ø> (ø)` | |
   | [pkg/graphql/utils/adapter.go](https://codecov.io/gh/apache/skywalking-cli/pull/82/diff?src=pr&el=tree#diff-cGtnL2dyYXBocWwvdXRpbHMvYWRhcHRlci5nbw==) | `29.16% <ø> (ø)` | |
   | [pkg/graphql/utils/constants.go](https://codecov.io/gh/apache/skywalking-cli/pull/82/diff?src=pr&el=tree#diff-cGtnL2dyYXBocWwvdXRpbHMvY29uc3RhbnRzLmdv) | `0.00% <ø> (ø)` | |
   | [internal/commands/interceptor/duration.go](https://codecov.io/gh/apache/skywalking-cli/pull/82/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY29tbWFuZHMvaW50ZXJjZXB0b3IvZHVyYXRpb24uZ28=) | `45.83% <50.00%> (ø)` | |
   | [internal/commands/interceptor/entity.go](https://codecov.io/gh/apache/skywalking-cli/pull/82/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY29tbWFuZHMvaW50ZXJjZXB0b3IvZW50aXR5Lmdv) | `42.42% <87.50%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/82?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/82?src=pr&el=footer). Last update [68ca77c...72d9b2e](https://codecov.io/gh/apache/skywalking-cli/pull/82?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] hanahmily commented on pull request #82: chore: reorganize the project layout and add an example of .skywalking.yaml

Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #82:
URL: https://github.com/apache/skywalking-cli/pull/82#issuecomment-748078825


   Noted. Actually, SWCK needs functions in `pkg` with an error return value, instead of exiting the process when facing some errors as below 
   
   ```
   func AllServices(cliCtx *cli.Context, duration api.Duration) ([]api.Service, error)
   ```
   
   Do you have any convenient path to support it? 
   The only downside of the current solution is SWCK has to copy the implementation of these functions, which brings some issues if the details of them are updated.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] fgksgf commented on a change in pull request #82: chore: reorganize the project layout and add an example of .skywalking.yaml

Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #82:
URL: https://github.com/apache/skywalking-cli/pull/82#discussion_r545756064



##########
File path: examples/skywalking.yaml
##########
@@ -0,0 +1,20 @@
+# Licensed to Apache Software Foundation (ASF) under one or more contributor
+# license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright
+# ownership. Apache Software Foundation (ASF) licenses this file to you under
+# the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+base-url: http://demo.skywalking.apache.org/graphql
+username: basic-auth-username
+password: basic-auth-password

Review comment:
       I think this file's name should be `.skywalking.yaml`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] fgksgf commented on a change in pull request #82: chore: reorganize the project layout and add an example of .skywalking.yaml

Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #82:
URL: https://github.com/apache/skywalking-cli/pull/82#discussion_r545786348



##########
File path: pkg/heatmap/axes/label.go
##########
@@ -108,7 +108,7 @@ func xLabels(yEnd image.Point, graphWidth int, stringLabels []string, cellWidth
 
 // paddedLabelLength calculates the length of the padded label and
 // the column index corresponding to the label.
-// For example, the longest label's length is 5, like '12:34', and the cell's width is 3.
+// For examples, the longest label's length is 5, like '12:34', and the cell's width is 3.

Review comment:
       I don't think `for examples` is correct.
   ![image](https://user-images.githubusercontent.com/26627380/102612188-3fa4c080-416b-11eb-8359-d2c8c14f987f.png)
   ![image](https://user-images.githubusercontent.com/26627380/102612255-59460800-416b-11eb-9afe-9d7c71ab4dce.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] kezhenxu94 commented on pull request #82: chore: reorganize the project layout and add an example of .skywalking.yaml

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #82:
URL: https://github.com/apache/skywalking-cli/pull/82#issuecomment-748100641


   @hanahmily done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] fgksgf commented on a change in pull request #82: chore: reorganize the project layout and add an example of .skywalking.yaml

Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #82:
URL: https://github.com/apache/skywalking-cli/pull/82#discussion_r545756064



##########
File path: examples/skywalking.yaml
##########
@@ -0,0 +1,20 @@
+# Licensed to Apache Software Foundation (ASF) under one or more contributor
+# license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright
+# ownership. Apache Software Foundation (ASF) licenses this file to you under
+# the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+base-url: http://demo.skywalking.apache.org/graphql
+username: basic-auth-username
+password: basic-auth-password

Review comment:
       I think this file's name should be `.skywalking.yml`, which is consistent with `README.md`. 
   And if there is a link to this file in `README.md` would be nice.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] kezhenxu94 commented on pull request #82: chore: reorganize the project layout and add an example of .skywalking.yaml

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #82:
URL: https://github.com/apache/skywalking-cli/pull/82#issuecomment-748083977


   > Noted. Actually, SWCK needs functions in `pkg` with an error return value, instead of exiting the process when facing some errors as below
   > 
   > ```
   > func AllServices(cliCtx *cli.Context, duration api.Duration) ([]api.Service, error)
   > ```
   > 
   > Do you have any convenient path to support it?
   > The only downside of the current solution is SWCK has to copy the implementation of these functions, which brings some issues if the details of them are updated.
   
   I see, we have this 
   
   https://github.com/apache/skywalking-cli/blob/2ed3443179b3995f44d5588c66716fe24b6f0341/pkg/graphql/client/client.go#L39
   
   and this
   
   https://github.com/apache/skywalking-cli/blob/2ed3443179b3995f44d5588c66716fe24b6f0341/pkg/graphql/client/client.go#L57
   
   the current query (`AllServices`, etc.) calls the latter one, so I think we can call the former one and let the `command` package to `panic` when there is an error, this should meet your requirement right? @hanahmily 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] kezhenxu94 edited a comment on pull request #82: chore: reorganize the project layout and add an example of .skywalking.yaml

Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #82:
URL: https://github.com/apache/skywalking-cli/pull/82#issuecomment-748085025


   
   Does it matter if we have other return values apart from the `error`? Like returning two values `string, error`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] hanahmily commented on pull request #82: chore: reorganize the project layout and add an example of .skywalking.yaml

Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #82:
URL: https://github.com/apache/skywalking-cli/pull/82#issuecomment-748088977


   > the current query (AllServices, etc.) calls the latter one, so I think we can call the former one and let the command package to panic when there is an error, this should meet your requirement right
   
   That's exactly what I expect, thanks zhenxu.
   
   > Does it matter if we have other return values apart from the error?
   
    It doesn't matter to SWCK, go for it.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] kezhenxu94 merged pull request #82: chore: reorganize the project layout and add an example of .skywalking.yaml

Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #82:
URL: https://github.com/apache/skywalking-cli/pull/82


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #82: chore: reorganize the project layout and add an example of .skywalking.yaml

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #82:
URL: https://github.com/apache/skywalking-cli/pull/82#discussion_r545787210



##########
File path: pkg/heatmap/axes/label.go
##########
@@ -108,7 +108,7 @@ func xLabels(yEnd image.Point, graphWidth int, stringLabels []string, cellWidth
 
 // paddedLabelLength calculates the length of the padded label and
 // the column index corresponding to the label.
-// For example, the longest label's length is 5, like '12:34', and the cell's width is 3.
+// For examples, the longest label's length is 5, like '12:34', and the cell's width is 3.

Review comment:
       Neither do I, the IDE changed too many




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] kezhenxu94 removed a comment on pull request #82: chore: reorganize the project layout and add an example of .skywalking.yaml

Posted by GitBox <gi...@apache.org>.
kezhenxu94 removed a comment on pull request #82:
URL: https://github.com/apache/skywalking-cli/pull/82#issuecomment-748100641


   @hanahmily done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #82: chore: reorganize the project layout and add an example of .skywalking.yaml

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #82:
URL: https://github.com/apache/skywalking-cli/pull/82#discussion_r545761898



##########
File path: examples/skywalking.yaml
##########
@@ -0,0 +1,20 @@
+# Licensed to Apache Software Foundation (ASF) under one or more contributor
+# license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright
+# ownership. Apache Software Foundation (ASF) licenses this file to you under
+# the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+base-url: http://demo.skywalking.apache.org/graphql
+username: basic-auth-username
+password: basic-auth-password

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] kezhenxu94 commented on pull request #82: chore: reorganize the project layout and add an example of .skywalking.yaml

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #82:
URL: https://github.com/apache/skywalking-cli/pull/82#issuecomment-748085025


   > > Noted. Actually, SWCK needs functions in `pkg` with an error return value, instead of exiting the process when facing some errors as below
   > > ```
   > > func AllServices(cliCtx *cli.Context, duration api.Duration) ([]api.Service, error)
   > > ```
   > > 
   > > 
   > > Do you have any convenient path to support it?
   > > The only downside of the current solution is SWCK has to copy the implementation of these functions, which brings some issues if the details of them are updated.
   > 
   > I see, we have this
   > 
   > https://github.com/apache/skywalking-cli/blob/2ed3443179b3995f44d5588c66716fe24b6f0341/pkg/graphql/client/client.go#L39
   > 
   > and this
   > 
   > https://github.com/apache/skywalking-cli/blob/2ed3443179b3995f44d5588c66716fe24b6f0341/pkg/graphql/client/client.go#L57
   > 
   > the current query (`AllServices`, etc.) calls the latter one, so I think we can call the former one and let the `command` package to `panic` when there is an error, this should meet your requirement right? @hanahmily
   
   Does it matter if we have other return values apart from the `error`? Like returning two values `string, error`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] codecov-io edited a comment on pull request #82: chore: reorganize the project layout and add an example of .skywalking.yaml

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #82:
URL: https://github.com/apache/skywalking-cli/pull/82#issuecomment-748101243


   # [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/82?src=pr&el=h1) Report
   > Merging [#82](https://codecov.io/gh/apache/skywalking-cli/pull/82?src=pr&el=desc) (0f5f388) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/68ca77c73eafc63a13178165d9d2ef4720b902e5?el=desc) (68ca77c) will **not change** coverage.
   > The diff coverage is `80.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking-cli/pull/82/graphs/tree.svg?width=650&height=150&src=pr&token=oivudZDTNJ)](https://codecov.io/gh/apache/skywalking-cli/pull/82?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master      #82   +/-   ##
   =======================================
     Coverage   44.89%   44.89%           
   =======================================
     Files           9        9           
     Lines         147      147           
   =======================================
     Hits           66       66           
     Misses         73       73           
     Partials        8        8           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking-cli/pull/82?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [internal/commands/interceptor/interceptor.go](https://codecov.io/gh/apache/skywalking-cli/pull/82/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY29tbWFuZHMvaW50ZXJjZXB0b3IvaW50ZXJjZXB0b3IuZ28=) | `0.00% <ø> (ø)` | |
   | [internal/commands/interceptor/timezone.go](https://codecov.io/gh/apache/skywalking-cli/pull/82/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY29tbWFuZHMvaW50ZXJjZXB0b3IvdGltZXpvbmUuZ28=) | `0.00% <ø> (ø)` | |
   | [pkg/display/json/json.go](https://codecov.io/gh/apache/skywalking-cli/pull/82/diff?src=pr&el=tree#diff-cGtnL2Rpc3BsYXkvanNvbi9qc29uLmdv) | `60.00% <ø> (ø)` | |
   | [pkg/display/table/table.go](https://codecov.io/gh/apache/skywalking-cli/pull/82/diff?src=pr&el=tree#diff-cGtnL2Rpc3BsYXkvdGFibGUvdGFibGUuZ28=) | `100.00% <ø> (ø)` | |
   | [pkg/display/yaml/yaml.go](https://codecov.io/gh/apache/skywalking-cli/pull/82/diff?src=pr&el=tree#diff-cGtnL2Rpc3BsYXkveWFtbC95YW1sLmdv) | `60.00% <ø> (ø)` | |
   | [pkg/graphql/utils/adapter.go](https://codecov.io/gh/apache/skywalking-cli/pull/82/diff?src=pr&el=tree#diff-cGtnL2dyYXBocWwvdXRpbHMvYWRhcHRlci5nbw==) | `29.16% <ø> (ø)` | |
   | [pkg/graphql/utils/constants.go](https://codecov.io/gh/apache/skywalking-cli/pull/82/diff?src=pr&el=tree#diff-cGtnL2dyYXBocWwvdXRpbHMvY29uc3RhbnRzLmdv) | `0.00% <ø> (ø)` | |
   | [internal/commands/interceptor/duration.go](https://codecov.io/gh/apache/skywalking-cli/pull/82/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY29tbWFuZHMvaW50ZXJjZXB0b3IvZHVyYXRpb24uZ28=) | `45.83% <50.00%> (ø)` | |
   | [internal/commands/interceptor/entity.go](https://codecov.io/gh/apache/skywalking-cli/pull/82/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY29tbWFuZHMvaW50ZXJjZXB0b3IvZW50aXR5Lmdv) | `42.42% <87.50%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/82?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/82?src=pr&el=footer). Last update [68ca77c...0f5f388](https://codecov.io/gh/apache/skywalking-cli/pull/82?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] kezhenxu94 commented on pull request #82: chore: reorganize the project layout and add an example of .skywalking.yaml

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #82:
URL: https://github.com/apache/skywalking-cli/pull/82#issuecomment-748475216


   The comments have been addressed. I'm merging, if anything else need to be done, please let me know @hanahmily :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org