You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/19 12:09:06 UTC
[GitHub] [arrow-rs] alamb opened a new pull request, #1910: minor: clarify docstring on `DictionaryArray::lookup_key`
alamb opened a new pull request, #1910:
URL: https://github.com/apache/arrow-rs/pull/1910
While working on something else I found another docstring I think could be improved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1910: minor: clarify docstring on `DictionaryArray::lookup_key`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1910:
URL: https://github.com/apache/arrow-rs/pull/1910#issuecomment-1159711025
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1910?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1910](https://codecov.io/gh/apache/arrow-rs/pull/1910?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c46d88e) into [master](https://codecov.io/gh/apache/arrow-rs/commit/ded63168de4dce7e4e92753bd39d60d20bfb683e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ded6316) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1910 +/- ##
==========================================
- Coverage 83.41% 83.41% -0.01%
==========================================
Files 214 214
Lines 56991 56991
==========================================
- Hits 47541 47539 -2
- Misses 9450 9452 +2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/array\_dictionary.rs](https://codecov.io/gh/apache/arrow-rs/pull/1910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X2RpY3Rpb25hcnkucnM=) | `91.91% <ø> (ø)` | |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.53% <0.00%> (-0.46%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1910?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1910?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ded6316...c46d88e](https://codecov.io/gh/apache/arrow-rs/pull/1910?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #1910: minor: clarify docstring on `DictionaryArray::lookup_key`
Posted by GitBox <gi...@apache.org>.
alamb merged PR #1910:
URL: https://github.com/apache/arrow-rs/pull/1910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1910: minor: clarify docstring on `DictionaryArray::lookup_key`
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1910:
URL: https://github.com/apache/arrow-rs/pull/1910#discussion_r901135825
##########
arrow/src/array/array_dictionary.rs:
##########
@@ -128,7 +128,11 @@ impl<'a, K: ArrowPrimitiveType> DictionaryArray<K> {
&self.keys
}
- /// Returns the lookup key by doing reverse dictionary lookup
+ /// If `value` is present in `values` (aka the dictionary),
+ /// returns the coresponding key (index into the `values`
Review Comment:
typo?
```suggestion
/// returns the corresponding key (index into the `values`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org