You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "zhaoxingyu12 (via GitHub)" <gi...@apache.org> on 2024/10/12 13:23:13 UTC
[PR] mtd/nvs: Trigger recovery process in nvs_startup [nuttx]
zhaoxingyu12 opened a new pull request, #14189:
URL: https://github.com/apache/nuttx/pull/14189
mtd/nvs: Trigger recovery process in nvs_startup when mtd driver return -EBADMSG
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] mtd/nvs: Trigger recovery process in nvs_startup [nuttx]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #14189:
URL: https://github.com/apache/nuttx/pull/14189#issuecomment-2408568425
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
**Missing Information to Determine if PR Meets Requirements:**
The provided PR title and code snippet are insufficient to assess compliance with NuttX PR requirements.
**To determine if the PR meets the requirements, we need:**
* **Complete PR Description:** The full PR description on GitHub, including the detailed "Summary" and "Impact" sections as outlined in the requirements.
* **Code Changes:** Access to the actual code modifications to understand the implementation details and their potential impact.
**Specifically, the following information is crucial:**
* **Purpose of the Change:** Why is it necessary to trigger recovery in `nvs_startup` when `-EBADMSG` is returned? What problem does this solve?
* **Functional Impact:** How does triggering the recovery process address the issue? What happens during recovery?
* **User Impact:** Will users experience any changes in behavior? Will any specific configurations be affected?
* **Hardware/Driver Impact:** Are there any dependencies on specific MTD drivers or hardware platforms?
* **Testing Details:** What specific tests were performed to verify the changes (beyond the provided logs)? What were the expected outcomes?
**Recommendation:**
Please provide the complete PR description and link to the PR on GitHub for a thorough review against the NuttX requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] mtd/nvs: Trigger recovery process in nvs_startup [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #14189:
URL: https://github.com/apache/nuttx/pull/14189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org