You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "nchammas (via GitHub)" <gi...@apache.org> on 2024/01/25 19:16:23 UTC
[PR] [SPARK-46863][DOCS] Cleanup custom CSS [spark]
nchammas opened a new pull request, #44885:
URL: https://github.com/apache/spark/pull/44885
### What changes were proposed in this pull request?
- Remove rules for the following classes that we do not use:
- `.code` (We use `code` _elements_, but not a `code` _class_.)
- `.code-tab` (We _do_ have a `codetabs` class, however.)
- `.jumbotron`
- Remove some superfluous comments.
- Using [css-purge][1], merge rules for the same selectors that were previous scattered across several blocks, and remove overridden rules.
- Format the whole file with VS Code. This makes the spacing consistent, and puts each selector on its own line.
[1]: http://rbtech.github.io/css-purge/
### Why are the changes needed?
It's very difficult to make improvements to the presentation of the documentation due to the noise in this CSS file. This change will facilitate future improvements to the documentation.
### Does this PR introduce _any_ user-facing change?
No, it shouldn't. This change should be functionally neutral.
### How was this patch tested?
I built the docs and manually reviewed them. Code blocks and tables look the same to me.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46863][DOCS] Cleanup custom CSS [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #44885:
URL: https://github.com/apache/spark/pull/44885#issuecomment-1910834241
cc @gengliangwang and @grundprinzip.
I am trying to fix how code and text inside tables wrap, but I found it very difficult to do due to a few problems in `custom.css`. This PR makes an initial round of cleanup.
In a future PR, I intend to reduce our use of the `.global` class selector, which is very invasive due to its [specificity][1], and makes it harder to define simple styling rules for tables.
[1]: https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46863][DOCS] Cleanup custom CSS [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #44885: [SPARK-46863][DOCS] Cleanup custom CSS
URL: https://github.com/apache/spark/pull/44885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46863][DOCS] Cleanup custom CSS [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #44885:
URL: https://github.com/apache/spark/pull/44885#issuecomment-1911350094
Thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org