[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8743: Fix a bunch of files with pylint disabled

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #8743: Fix a bunch of files with pylint disabled
URL: https://github.com/apache/incubator-superset/pull/8743#discussion_r353481583
 
 

 ##########
 File path: superset/sql_lab.py
 ##########
 @@ -202,15 +199,15 @@ def execute_sql_statement(sql_statement, query, user_name, session, cursor):
         sql = parsed_query.as_create_table(query.tmp_table_name)
         query.select_as_cta_used = True
     if parsed_query.is_select():
-        if SQL_MAX_ROWS and (not query.limit or query.limit > SQL_MAX_ROWS):
-            query.limit = SQL_MAX_ROWS
+        if sql_max_rows and (not query.limit or query.limit > sql_max_rows):
+            query.limit = sql_max_rows
         if query.limit:
             sql = database.apply_limit_to_sql(sql, query.limit)
 
     # Hook to allow environment-specific mutation (usually comments) to the SQL
-    SQL_QUERY_MUTATOR = config["SQL_QUERY_MUTATOR"]
-    if SQL_QUERY_MUTATOR:
-        sql = SQL_QUERY_MUTATOR(sql, user_name, security_manager, database)
+    sql_query_mutator = config["SQL_QUERY_MUTATOR"]
 
 Review comment:
   same comment here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org