You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by GitBox <gi...@apache.org> on 2021/07/30 09:27:44 UTC

[GitHub] [jmeter] rithvikp1998 opened a new pull request #671: Fix to 65446 - Move statistic_window property to user.properties file

rithvikp1998 opened a new pull request #671:
URL: https://github.com/apache/jmeter/pull/671


   ## Description
   PercentileAggregator class reads the value for statistic_window using the following line:
   
   ```
   private static final int SLIDING_WINDOW_SIZE = JMeterUtils.getPropDefault(
               ReportGeneratorConfiguration.REPORT_GENERATOR_KEY_PREFIX
                       + ReportGeneratorConfiguration.KEY_DELIMITER
                       + "statistic_window", 20000);
   ```
   getPropDefault() calls appProperties.getProperty(). But in the appProperties we are only loading jmeter.properties, user.properties, system.properties etc and _not_ reportgenerator.properties where the value for statistic_window is supposed to be set. So the default value of 20,000 is being picked irrespective of what is set in the properties file.
   
   _There are multiple ways to fix this issue but I chose this approach because it is the least intrusive._
   
   ## Motivation and Context
   https://bz.apache.org/bugzilla/show_bug.cgi?id=65446
   
   ## How Has This Been Tested?
   I built the code with the new changes and generated dashboards with some debug log statements in the code. The dashboards were getting generated correctly and the log statements are printing whatever property value I am setting. (Without this patch, they always print 20,000 as the size of the statistic window even when I am setting a different value in reportgenerator.properties file)
   
   ## Screenshots (if appropriate):
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Delete as appropriate -->
   - Bug fix (non-breaking change which fixes an issue)
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   - [x] My code follows the [code style][style-guide] of this project.
   - [ ] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] FSchumacher commented on pull request #671: Fix to 65446 - Move statistic_window property to user.properties file

Posted by GitBox <gi...@apache.org>.
FSchumacher commented on pull request #671:
URL: https://github.com/apache/jmeter/pull/671#issuecomment-903108558


   Thanks for the PR it has been merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] FSchumacher commented on pull request #671: Fix to 65446 - Move statistic_window property to user.properties file

Posted by GitBox <gi...@apache.org>.
FSchumacher commented on pull request #671:
URL: https://github.com/apache/jmeter/pull/671#issuecomment-895201794


   I think, this is a valid fix, as the documentation does not state, where the property would have to be placed and *reportgenerator.properties* is not used for general properties and there are a few other reportgenerator related properties already defined in *users.properties*.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] rithvikp1998 commented on pull request #671: Fix to 65446 - Move statistic_window property to user.properties file

Posted by GitBox <gi...@apache.org>.
rithvikp1998 commented on pull request #671:
URL: https://github.com/apache/jmeter/pull/671#issuecomment-895705846


   @FSchumacher Can we get this merged then? Or is there anything else I need to do?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] asfgit closed pull request #671: Fix to 65446 - Move statistic_window property to user.properties file

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #671:
URL: https://github.com/apache/jmeter/pull/671


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org