You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/29 19:57:52 UTC

[GitHub] [arrow-datafusion] tustvold opened a new pull request, #4021: Project columns within DatafusionArrowPredicate (#4005) (#4006)

tustvold opened a new pull request, #4021:
URL: https://github.com/apache/arrow-datafusion/pull/4021

   _Draft as I need to add tests, but run out of time for now_
   
   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #4005 
   Closes #4006
   
   # Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   See tickets
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Project batch in DatafusionArrowPredicate according to the order expected by the PhysicalExpr
   
   # Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #4021: Project columns within DatafusionArrowPredicate (#4005) (#4006)

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4021:
URL: https://github.com/apache/arrow-datafusion/pull/4021#issuecomment-1296223818

   I'll plan to merge this in tomorrow unless anyone else would like to comment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #4021: Fix predicate pushdown bugs: project columns within DatafusionArrowPredicate (#4005) (#4006)

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4021:
URL: https://github.com/apache/arrow-datafusion/pull/4021#issuecomment-1296231810

   This PR had a conflict after merging https://github.com/apache/arrow-datafusion/pull/3989 
   
   ![Screen Shot 2022-10-30 at 7 44 22 AM](https://user-images.githubusercontent.com/490673/198876657-2fbae9fe-f78f-4d5f-a131-1b7efe88e62b.png)
   
   I took the liberty of fixing the merge conflict and pushing the fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] ursabot commented on pull request #4021: Fix predicate pushdown bugs: project columns within DatafusionArrowPredicate (#4005) (#4006)

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4021:
URL: https://github.com/apache/arrow-datafusion/pull/4021#issuecomment-1296367871

   Benchmark runs are scheduled for baseline = f4d70ac3e1c4298f9ea5ebb12855a95d60d2b737 and contender = 35f786bb6ce33cbd58db3e16a46958b58f7676f4. 35f786bb6ce33cbd58db3e16a46958b58f7676f4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/56b024be114d428db9d1693ffe57468e...f85a724702434ac6af43e55652fedf57/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/37705717f2634c15978b36a14e6c3cde...219f0212f5a04b7fb51acff0e2738051/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/c7c8b49350ef4b0daf9813a90f00b5a9...41bdc466d5ac4909a4210a4924216b18/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3f4b98ac0e4047f1a34089380c3dd656...b0fb86b8a1fe48958775c3c93abf30cd/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] tustvold merged pull request #4021: Fix predicate pushdown bugs: project columns within DatafusionArrowPredicate (#4005) (#4006)

Posted by GitBox <gi...@apache.org>.
tustvold merged PR #4021:
URL: https://github.com/apache/arrow-datafusion/pull/4021


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #4021: Fix predicate pushdown bugs: project columns within DatafusionArrowPredicate (#4005) (#4006)

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4021:
URL: https://github.com/apache/arrow-datafusion/pull/4021#issuecomment-1297311607

   I found another related bug: https://github.com/apache/arrow-datafusion/issues/4046


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org