You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by cgoodale <gi...@git.apache.org> on 2014/07/08 17:26:46 UTC
[GitHub] climate pull request: CLIMATE-489 Improve Subset Bounds Error Mess...
GitHub user cgoodale opened a pull request:
https://github.com/apache/climate/pull/87
CLIMATE-489 Improve Subset Bounds Error Message
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cgoodale/climate CLIMATE-489
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/87.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #87
----
commit 16a226ac192332743fa0dcf3cdc85e496219665b
Author: cgoodale <si...@gmail.com>
Date: 2014-07-08T14:39:45Z
Add better subset error reporting
* Using a try/expect block instead of Boolean comparison
* Updated the docstring on subset function
* Building up a list of errors to support multiple errors in one pass
commit b49042db5fd6dac5a11b413c65e472acd04364b4
Author: cgoodale <si...@gmail.com>
Date: 2014-07-08T14:57:49Z
Remove extra Try/Except block
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-489 Improve Subset Bounds Error Mess...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/87#issuecomment-48354087
Merged build started. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-489 Improve Subset Bounds Error Mess...
Posted by cgoodale <gi...@git.apache.org>.
Github user cgoodale closed the pull request at:
https://github.com/apache/climate/pull/87
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-489 Improve Subset Bounds Error Mess...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/87#issuecomment-48354420
Merged build finished. Test Passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-489 Improve Subset Bounds Error Mess...
Posted by MJJoyce <gi...@git.apache.org>.
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/87#issuecomment-48909815
:+1: Looks good to me! I'll go ahead an merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-489 Improve Subset Bounds Error Mess...
Posted by cgoodale <gi...@git.apache.org>.
Github user cgoodale commented on the pull request:
https://github.com/apache/climate/pull/87#issuecomment-48939080
@MJJoyce merged this PR already, so I am closing it out now. Thanks Mike.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-489 Improve Subset Bounds Error Mess...
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/87#issuecomment-48354067
Merged build triggered. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---