[jira] Issue Comment Edited: (WINK-47) honor media type wildcards

["Mike Rheinheimer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WINK-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728342#action_12728342 ] 

Mike Rheinheimer edited comment on WINK-47 at 7/7/09 1:17 PM:
--------------------------------------------------------------

Ok, I re-worked the solution to no longer use regular expressions, or override the LinkeHashMap.get method.  Instead, I now iterate through the entries in the map, use MediaType.isCompatible to compare the mediaType param with the keys in the map, and collect the data in order per JAX-RS 4.3.1.  Please review the patch_02.txt and see what you think.

NOTE:  I did have to change two existing test methods -- please be sure to see the changes and agree or disagree with my reasoning in the code comments.

I like this kind of dialog for these types of issues.  Good teamwork.  Thanks!

      was (Author: rott):
    Ok, I re-worked the solution to no longer use regular expressions, or override the LinkeHashMap.get method.  Instead, I now iterate through the entries in the map, use MediaType.isCompatible to compare the mediaType param with the keys in the map, and collect the data in order per JAX-RS 4.3.1.  Please review the patch02.txt and see what you think.

NOTE:  I did have to change two existing test methods -- please be sure to see the changes and agree or disagree with my reasoning in the code comments.

I like this kind of dialog for these types of issues.  Good teamwork.  Thanks!
  
> honor media type wildcards
> --------------------------
>
>                 Key: WINK-47
>                 URL: https://issues.apache.org/jira/browse/WINK-47
>             Project: Wink
>          Issue Type: Bug
>          Components: Common
>    Affects Versions: 0.1
>            Reporter: Mike Rheinheimer
>             Fix For: 0.1
>
>         Attachments: patch.txt, patch_02.txt
>
>
> This issue probably needs discussion, as it may be a spec interpretation issue.  Please reference JAX-RS javadoc for javax.ws.rs.ext.Providers.getContextResolver here:
> http://jackson.codehaus.org/javadoc/jax-rs/1.0/javax/ws/rs/ext/Providers.html#getContextResolver(java.lang.Class,%20javax.ws.rs.core.MediaType)
> Currently, the implementation does not use the '*' character in a passed-in media type as a wildcard.  Rather, it matches exactly by just allowing the LinkedHashMap.get to it's object compare.  Attached is a patch with tests that demonstrate the proposed function, and a fix that supports it.  All existing and new tests in wink-common and wink-server passed for me with this change.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.