You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/02/28 07:01:36 UTC
[GitHub] [incubator-doris] yangzhg opened a new pull request #3015: change
set operation from random shuffle to hash shuffle
yangzhg opened a new pull request #3015: change set operation from random shuffle to hash shuffle
URL: https://github.com/apache/incubator-doris/pull/3015
#3009
use hash shuffle instead of random shuffle in set operation, prepare for intersect and except operation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wutiangan commented on a change in pull request
#3015: change set operation from random shuffle to hash shuffle
Posted by GitBox <gi...@apache.org>.
wutiangan commented on a change in pull request #3015: change set operation from random shuffle to hash shuffle
URL: https://github.com/apache/incubator-doris/pull/3015#discussion_r386186248
##########
File path: fe/src/main/java/org/apache/doris/analysis/SetOperationStmt.java
##########
@@ -649,7 +649,9 @@ public void analyze(Analyzer parent) throws AnalysisException, UserException {
if (isAnalyzed()) {
return;
}
- if (qualifier_ == Qualifier.ALL && operation != Operation.UNION) {
+ // Oracle and ms-SQLServer are not support INTERSECT ALL and EXCEPT ALL, postgres support it,
Review comment:
are not --> do not
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #3015: change set
operation from random shuffle to hash shuffle
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #3015: change set operation from random shuffle to hash shuffle
URL: https://github.com/apache/incubator-doris/pull/3015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wutiangan commented on a change in pull request
#3015: change set operation from random shuffle to hash shuffle
Posted by GitBox <gi...@apache.org>.
wutiangan commented on a change in pull request #3015: change set operation from random shuffle to hash shuffle
URL: https://github.com/apache/incubator-doris/pull/3015#discussion_r386186055
##########
File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
##########
@@ -1717,19 +1723,30 @@ private PlanNode createPartialSetOperationPlan(Analyzer analyzer, SetOperationSt
hasAllOps = true;
allOps.add(op);
}
+ if (operation == null || operation == op.getOperation()) {
+ operation = op.getOperation();
Review comment:
add comments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org