[GitHub] [zookeeper] tisonkun commented on a diff in pull request #2006: ZOOKEEPER-4472: Remove persistent watches individually

["tisonkun (via GitHub)" <gi...@apache.org>]

tisonkun commented on code in PR #2006:
URL: https://github.com/apache/zookeeper/pull/2006#discussion_r1228402918


##########
zookeeper-server/src/main/java/org/apache/zookeeper/ZKWatchManager.java:
##########
@@ -225,18 +237,6 @@ void containsWatcher(String path, Watcher watcher, Watcher.WatcherType watcherTy
             synchronized (childWatches) {
                 containsWatcher = contains(path, watcher, childWatches);
             }
-

Review Comment:
   I agree on this direction that it delivers more reasonable behaviors. But it can somehow still a user-facing manner changes. Maybe we need a release note to describe it.
   
   I'll check the final logic tomorrow and give a review result :D



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org