You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/20 08:37:12 UTC
[GitHub] [spark] MaxGekk opened a new pull request #28878: [SPARK-32021][SQL][3.0] Increase precision of seconds and fractions of `make_interval`
MaxGekk opened a new pull request #28878:
URL: https://github.com/apache/spark/pull/28878
### What changes were proposed in this pull request?
Change precision of seconds and its fraction from 8 to 18 to be able to construct intervals of max allowed microseconds value (long).
### Why are the changes needed?
To improve UX of Spark SQL.
### Does this PR introduce _any_ user-facing change?
Yes
### How was this patch tested?
- Add tests to IntervalExpressionsSuite
- Add an example to the `MakeInterval` expression
- Add tests to `interval.sql`
Authored-by: Max Gekk max.gekk@gmail.com
Signed-off-by: Dongjoon Hyun dongjoon@apache.org
(cherry picked from commit 66ba35666a49023cd8da30cf84aff5c6fb1d8799)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28878: [SPARK-32021][SQL][3.0] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28878:
URL: https://github.com/apache/spark/pull/28878#issuecomment-647028768
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28878: [SPARK-32021][SQL][3.0] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28878:
URL: https://github.com/apache/spark/pull/28878
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28878: [SPARK-32021][SQL][3.0] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28878:
URL: https://github.com/apache/spark/pull/28878#issuecomment-646963932
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28878: [SPARK-32021][SQL][3.0] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28878:
URL: https://github.com/apache/spark/pull/28878#issuecomment-646992664
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28878: [SPARK-32021][SQL][3.0] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28878:
URL: https://github.com/apache/spark/pull/28878#issuecomment-646963825
**[Test build #124319 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124319/testReport)** for PR 28878 at commit [`8ddc76b`](https://github.com/apache/spark/commit/8ddc76b5f33932188f46419e81bc50e94ab09f4f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28878: [SPARK-32021][SQL][3.0] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28878:
URL: https://github.com/apache/spark/pull/28878#issuecomment-646963932
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28878: [SPARK-32021][SQL][3.0] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28878:
URL: https://github.com/apache/spark/pull/28878#issuecomment-646992664
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28878: [SPARK-32021][SQL][3.0] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28878:
URL: https://github.com/apache/spark/pull/28878#issuecomment-646992438
**[Test build #124319 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124319/testReport)** for PR 28878 at commit [`8ddc76b`](https://github.com/apache/spark/commit/8ddc76b5f33932188f46419e81bc50e94ab09f4f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28878: [SPARK-32021][SQL][3.0] Increase precision of seconds and fractions of `make_interval`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28878:
URL: https://github.com/apache/spark/pull/28878#issuecomment-646963825
**[Test build #124319 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124319/testReport)** for PR 28878 at commit [`8ddc76b`](https://github.com/apache/spark/commit/8ddc76b5f33932188f46419e81bc50e94ab09f4f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org