You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/06/10 14:53:34 UTC
[GitHub] [incubator-shenyu] dragon-zhang opened a new issue, #3521: [Task] add integration tests for shared thread pool
dragon-zhang opened a new issue, #3521:
URL: https://github.com/apache/incubator-shenyu/issues/3521
### Description
As a subtask of https://github.com/apache/incubator-shenyu/issues/3026, we need to add some integration tests to make sure that shared thread pool is working fine.
### Task List
1. - [ ] add integration test in `shenyu-integrated-test-alibaba-dubbo`;
2. - [ ] add integration test in `shenyu-integrated-test-apache-dubbo`; @dragon-zhang
3. - [ ] add integration test in `shenyu-integrated-test-grpc`;
4. - [ ] add integration test in `shenyu-integrated-test-motan`;
5. - [ ] add integration test in `shenyu-integrated-test-sofa`;
6. - [ ] add integration test in `shenyu-integrated-test-combination`; @dragon-zhang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] ShawnSiao commented on issue #3521: [Task] add integration tests for shared thread pool
Posted by GitBox <gi...@apache.org>.
ShawnSiao commented on issue #3521:
URL: https://github.com/apache/incubator-shenyu/issues/3521#issuecomment-1152939041
Please assign 5 to me, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] sunshujie1990 commented on issue #3521: [Task] add integration tests for shared thread pool
Posted by GitBox <gi...@apache.org>.
sunshujie1990 commented on issue #3521:
URL: https://github.com/apache/incubator-shenyu/issues/3521#issuecomment-1153873068
@dragon-zhang Hi dragon. While adding the `shenyu.sharedPool.enable` property, my ide (IntelliJ IDEA) autocomplete the property key to `shenyu.shared-pool.enable` which results shared thread pool not effective. I think this is because of the implemention does not follow spring-boot's specification.
Shenyu implemention:
```
@Bean
@ConditionalOnProperty(name = "shenyu.sharedPool.enable", havingValue = "true")
```
spring-boot doc:
```
/**
* The name of the properties to test. If a prefix has been defined, it is applied to
* compute the full key of each property. For instance if the prefix is
* {@code app.config} and one value is {@code my-value}, the full key would be
* {@code app.config.my-value}
* <p>
* Use the dashed notation to specify each property, that is all lower case with a "-"
* to separate words (e.g. {@code my-long-property}).
* @return the names
*/
String[] name() default {};
```
https://github.com/spring-projects/spring-boot/blob/2.6.x/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/ConditionalOnProperty.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 closed issue #3521: [Task] add integration tests for shared thread pool
Posted by GitBox <gi...@apache.org>.
yu199195 closed issue #3521: [Task] add integration tests for shared thread pool
URL: https://github.com/apache/incubator-shenyu/issues/3521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] sunshujie1990 commented on issue #3521: [Task] add integration tests for shared thread pool
Posted by GitBox <gi...@apache.org>.
sunshujie1990 commented on issue #3521:
URL: https://github.com/apache/incubator-shenyu/issues/3521#issuecomment-1154631029
Sure. I will create a new issue to track the problem later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 closed issue #3521: [Task] add integration tests for shared thread pool
Posted by GitBox <gi...@apache.org>.
yu199195 closed issue #3521: [Task] add integration tests for shared thread pool
URL: https://github.com/apache/incubator-shenyu/issues/3521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] dragon-zhang commented on issue #3521: [Task] add integration tests for shared thread pool
Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on issue #3521:
URL: https://github.com/apache/incubator-shenyu/issues/3521#issuecomment-1152450153
I will do task2 and task6, the other tasks are yours. It is recommended that other tasks by referring to task2 after I complete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] dragon-zhang commented on issue #3521: [Task] add integration tests for shared thread pool
Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on issue #3521:
URL: https://github.com/apache/incubator-shenyu/issues/3521#issuecomment-1153951487
> @dragon-zhang Hi dragon. While adding the `shenyu.sharedPool.enable` property, my ide (IntelliJ IDEA) autocomplete the property key to `shenyu.shared-pool.enable` which results shared thread pool not effective. I think this is because of the implemention does not follow spring-boot's specification.
>
> Shenyu implemention:
>
> ```
> @Bean
> @ConditionalOnProperty(name = "shenyu.sharedPool.enable", havingValue = "true")
> ```
>
> spring-boot doc:
>
> ```
> /**
> * The name of the properties to test. If a prefix has been defined, it is applied to
> * compute the full key of each property. For instance if the prefix is
> * {@code app.config} and one value is {@code my-value}, the full key would be
> * {@code app.config.my-value}
> * <p>
> * Use the dashed notation to specify each property, that is all lower case with a "-"
> * to separate words (e.g. {@code my-long-property}).
> * @return the names
> */
> String[] name() default {};
> ```
>
> https://github.com/spring-projects/spring-boot/blob/2.6.x/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/ConditionalOnProperty.java
Can you help me find and deal with other similar places?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] renzhuyan commented on issue #3521: [Task] add integration tests for shared thread pool
Posted by GitBox <gi...@apache.org>.
renzhuyan commented on issue #3521:
URL: https://github.com/apache/incubator-shenyu/issues/3521#issuecomment-1152478465
Please assign 1 to me, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] MichaelDeSteven commented on issue #3521: [Task] add integration tests for shared thread pool
Posted by GitBox <gi...@apache.org>.
MichaelDeSteven commented on issue #3521:
URL: https://github.com/apache/incubator-shenyu/issues/3521#issuecomment-1152850107
plz asign task3 to me, thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] sunshujie1990 commented on issue #3521: [Task] add integration tests for shared thread pool
Posted by GitBox <gi...@apache.org>.
sunshujie1990 commented on issue #3521:
URL: https://github.com/apache/incubator-shenyu/issues/3521#issuecomment-1153664479
Please assign task 4 to me, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org