[jclouds] Fix Softlayer template options (#654)

[Andrew Donald Kennedy <no...@github.com>]

Changed the builder methods to return `SoftLayerTemplateOptions` to allow chaining. Always set the `diskType` when creating a VM, even if no block device configured, to allow use of `LOCAL` disk.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/654

-- Commit Summary --

  * Fix Softlayer template options to return correct type and set disk types even if no block device configures

-- File Changes --

    M providers/softlayer/src/main/java/org/jclouds/softlayer/compute/options/SoftLayerTemplateOptions.java (28)
    M providers/softlayer/src/main/java/org/jclouds/softlayer/compute/strategy/SoftLayerComputeServiceAdapter.java (4)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/654.patch
https://github.com/jclouds/jclouds/pull/654.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/654

Re: [jclouds] Fix Softlayer template options (#654)

[Ignasi Barrera <no...@github.com>]

That's right. When in doubt, you can check the builds at: https://jclouds.ci.cloudbees.com/
Those run after every commit and publish the snapshots to the snapshots repo.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/654#issuecomment-71871560

Re: [jclouds] Fix Softlayer template options (#654)

[Andrea Turli <no...@github.com>]

Merged as https://git1-us-west.apache.org/repos/asf?p=jclouds.git;a=commit;h=9e1d1cbfa9e2d77fe8b7e8feeae0bb4222654692

@grkvlt thanks!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/654#issuecomment-71800808

Re: [jclouds] Fix Softlayer template options (#654)

[Andrea Turli <no...@github.com>]

Closed #654.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/654#event-225930035

Re: [jclouds] Fix Softlayer template options (#654)

[Andrea Turli <no...@github.com>]

thanks @grkvlt! lgtm +1

merging now

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/654#issuecomment-71797889

Re: [jclouds] Fix Softlayer template options (#654)

[Andrew Donald Kennedy <no...@github.com>]

@andreaturli will this become part of jclouds 1.9.0 as well as 2.0.0 then?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/654#issuecomment-71861410

Re: [jclouds] Fix Softlayer template options (#654)

[Andrew Donald Kennedy <no...@github.com>]

@andreaturli Can you have a look at this, please?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/654#issuecomment-71707229

Re: [jclouds] Fix Softlayer template options (#654)

[Andrea Turli <no...@github.com>]

correct! it should be already available in 2.0.0-SNAPSHOT available in maven central, I think. 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/654#issuecomment-71862219