You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "linguini1 (via GitHub)" <gi...@apache.org> on 2025/03/10 22:04:34 UTC

[PR] drivers/wireless/lpwan/rn2xx3: Fix UART dependency [nuttx]

linguini1 opened a new pull request, #15967:
URL: https://github.com/apache/nuttx/pull/15967

   ## Summary
   
   There is no 'UART' symbol to depend on, so this dependency is removed for now. The driver will fail to register without being passed a UART character driver path anyways.
   
   ## Impact
   
   Users can now actually select this driver.
   
   ## Testing
   
   Before this change, the RN2XX3 does not show up under the LPWAN configuration menu. After this change, it does, and it builds successfully when selected. Testing performed with an STM32H743 image.
   
   ![image](https://github.com/user-attachments/assets/1d232f61-2bee-4a12-9044-1e3d08fa877f)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] drivers/wireless/lpwan/rn2xx3: Fix UART dependency [nuttx]

Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on code in PR #15967:
URL: https://github.com/apache/nuttx/pull/15967#discussion_r1988763112


##########
drivers/wireless/lpwan/Kconfig:
##########
@@ -8,7 +8,6 @@ if DRIVERS_LPWAN
 config LPWAN_RN2XX3
 	bool "Microchip RN2xx3 driver support"
 	default n
-	depends on UART

Review Comment:
   maybe `depends on SERIAL` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] drivers/wireless/lpwan/rn2xx3: Fix UART dependency [nuttx]

Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl merged PR #15967:
URL: https://github.com/apache/nuttx/pull/15967


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org