You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Remus Rusanu <re...@microsoft.com> on 2013/10/30 15:07:08 UTC

Review Request 15095: Make the VectorGroupByOperator memory pressure factors configurable

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15095/
-----------------------------------------------------------

Review request for hive, Gopal V and Jitendra Pandey.


Bugs: HIVE-5692
    https://issues.apache.org/jira/browse/HIVE-5692


Repository: hive-git


Description
-------

Fix HIVE-5692 make VectorGroupByOperator respond more aggressively to memory pressure and provide configuration knobs for the memory pressure parameters (checking interval, percent flushed).


Diffs
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3a8efcd 
  conf/hive-default.xml.template 5da90ec 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java 735122e 
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java d1d2ea9 

Diff: https://reviews.apache.org/r/15095/diff/


Testing
-------

Added new unit test


Thanks,

Remus Rusanu


Re: Review Request 15095: Make the VectorGroupByOperator memory pressure factors configurable

Posted by Gopal V <go...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15095/#review28670
-----------------------------------------------------------

Ship it!


Ship It!

- Gopal V


On Oct. 30, 2013, 6:10 p.m., Remus Rusanu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15095/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2013, 6:10 p.m.)
> 
> 
> Review request for hive, Gopal V and Jitendra Pandey.
> 
> 
> Bugs: HIVE-5692
>     https://issues.apache.org/jira/browse/HIVE-5692
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Fix HIVE-5692 make VectorGroupByOperator respond more aggressively to memory pressure and provide configuration knobs for the memory pressure parameters (checking interval, percent flushed).
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3a8efcd 
>   conf/hive-default.xml.template 5da90ec 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java 735122e 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java d1d2ea9 
> 
> Diff: https://reviews.apache.org/r/15095/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test
> 
> 
> Thanks,
> 
> Remus Rusanu
> 
>


Re: Review Request 15095: Make the VectorGroupByOperator memory pressure factors configurable

Posted by Remus Rusanu <re...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15095/
-----------------------------------------------------------

(Updated Oct. 30, 2013, 6:10 p.m.)


Review request for hive, Gopal V and Jitendra Pandey.


Bugs: HIVE-5692
    https://issues.apache.org/jira/browse/HIVE-5692


Repository: hive-git


Description
-------

Fix HIVE-5692 make VectorGroupByOperator respond more aggressively to memory pressure and provide configuration knobs for the memory pressure parameters (checking interval, percent flushed).


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3a8efcd 
  conf/hive-default.xml.template 5da90ec 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java 735122e 
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java d1d2ea9 

Diff: https://reviews.apache.org/r/15095/diff/


Testing
-------

Added new unit test


Thanks,

Remus Rusanu