You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/08 19:12:53 UTC

[GitHub] [pulsar] lhotari commented on a diff in pull request #17545: [improve][misc] Pull request template

lhotari commented on code in PR #17545:
URL: https://github.com/apache/pulsar/pull/17545#discussion_r966331554


##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -53,31 +50,29 @@ This change added tests and can be verified as follows:
 
 ### Does this pull request potentially affect one of the following parts:
 
-*If `yes` was chosen, please highlight the changes*
+*If the box was checked, please highlight the changes*
 
-  - Dependencies (does it add or upgrade a dependency): (yes / no)
-  - The public API: (yes / no)
-  - The schema: (yes / no / don't know)
-  - The default values of configurations: (yes / no)
-  - The wire protocol: (yes / no)
-  - The rest endpoints: (yes / no)
-  - The admin cli options: (yes / no)
-  - Anything that affects deployment: (yes / no / don't know)
+- [ ] Dependencies (add or upgrade a dependency)
+- [ ] The public API
+- [ ] The schema
+- [ ] The default values of configurations
+- [ ] The binary protocol
+- [ ] The REST endpoints
+- [ ] The admin CLI options
+- [ ] Anything that affects deployment
 
 ### Documentation
 
-Check the box below or label this PR directly.
-
-Need to update docs? 
+**DO NOT REMOVE THIS SECTION. CHECK PROPER BOX ONLY.**

Review Comment:
   Could this be in a markdown comment?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org