[GitHub] [airflow] mik-laj commented on a change in pull request #10162: Add Airflow UI site_title configuration option

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #10162:
URL: https://github.com/apache/airflow/pull/10162#discussion_r506498927



##########
File path: airflow/www/views.py
##########
@@ -515,11 +515,14 @@ def get_int_arg(value, default=0):
         state_color_mapping = State.state_color.copy()
         state_color_mapping["null"] = state_color_mapping.pop(None)
 
+        page_title = conf.get(section="webserver", key="site_title", fallback="DAGs")

Review comment:
       I think we can use a more generic option name like `instance_name` which will be empty by default. When it is set, some strings will be replaced with the name of the instance, and in other cases, the description will be used more appropriately to the case. I don't see the benefit of splitting this into two options if the user will always set identical values two after. I don't see the benefit of splitting this into two options if the user always sets the same values in the two options. We really want to get it to be able to easily recognize different environments/instances of this application.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org