You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/21 06:02:04 UTC
[GitHub] [spark] MaxGekk commented on a diff in pull request #36284: [SPARK-38750][SQL][TESTS] Test the error class: SECOND_FUNCTION_ARGUMENT_NOT_INTEGER
MaxGekk commented on code in PR #36284:
URL: https://github.com/apache/spark/pull/36284#discussion_r854809719
##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryCompilationErrorsSuite.scala:
##########
@@ -362,6 +362,19 @@ class QueryCompilationErrorsSuite extends QueryTest with SharedSparkSession {
}
}
}
+
+ test("SECOND_FUNCTION_ARGUMENT_NOT_INTEGER: " +
+ "the second argument of 'date_add' function needs to be an integer") {
+ withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {
Review Comment:
We shouldn't have different exception stacks, we need to fix this. @panbingkun Could you open an issue w/ example how to reproduce the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org