Re: [Discuss] Proposal to introduce new mime type to support non-typed Graphson-1.0

[Stephen Mallette <sp...@gmail.com>]

Just wanted to point out that in discussion on the PR, the mime type has
been changed from "sparse=true" to "typed=false" as it seems to better suit
the format and matches the naming conventions we sort of already
established. Going to make one more change in master to get everything
wholly consistent and to get rid of some old deprecated code. Specifically:

1. Remove GraphSONMessageSerializerGremlinV2d0 deprecated in 3.4.0.
2. Remove GraphSONMessageSerializerGremlinV1d0 which under our naming
conventions should be GraphSONMessageSerializerV1d0 (this has been
confusing since the naming shifted at 3.4.0)
3. Drop the "d0" on the names of all the serializers to match GraphBinary.

That should make all of 3.7.0 set up nicely. Also, expect to make GraphSON
3.0 have an untyped variation to match 1 and 2.


On Thu, Jun 29, 2023 at 11:46 AM Sai Phanindhra <ph...@gmail.com> wrote:

> Hi cole,
>
> Thank you for the reply. I went ahead and made necessary changes to
> introduce a new mime type to be able to use GraphSON-1.0 for Http.
>
> PR: https://github.com/apache/tinkerpop/pull/2115
>
> Kindly review.
>
> On Wed, Jun 28, 2023 at 1:07 AM Cole Greer <Cole.Greer@improving.com
> .invalid>
> wrote:
>
> > Hi Sai,
> >
> > This is admittedly not my area of expertise, but I personally don’t see
> > any issue with adding an additional MIME type for GraphSON 1.0. If you
> can
> > get a PR submitted sometime in the next 2 weeks or so I don’t see any
> > reason why this couldn’t be included in 3.7.0.
> >
> > Regards,
> >
> > Cole Greer
> >
> > From: Sai Phanindhra <ph...@gmail.com>
> > Date: Tuesday, June 27, 2023 at 9:39 AM
> > To: dev@tinkerpop.apache.org <de...@tinkerpop.apache.org>
> > Subject: [Discuss] Proposal to introduce new mime type to support
> > non-typed Graphson-1.0
> > Hi all,
> >    In the graph implementation i'm working on, we return text json format
> > of GraphSON for the http apis. Existing implementation of Tinkerpop
> > uses GraphSONMessageSerializerGremlinV1d0
> > as the serializer for GraphSon-1.0(application/vnd.gremlin-v1.0+json).
> This
> > serializer does not implement the interface MessageTextSerializer which
> is
> > needed to serialize/deserialize graph query response as string and vice
> > versa. Customers who intend to use GraphSon-1.0(
> > application/vnd.gremlin-v1.0+json) are blocked due to this behavior.
> >
> > I have the following proposal to mitigate this issue.
> >
> > 1. Use Serializer GraphSONMessageSerializerV1d0 as the serializer for
> > GraphSon-1.0(application/vnd.gremlin-v1.0+json) for Http APIs
> > 2. Or Introduce a new mime type (say
> > application/vnd.gremlin-v1.0+json-text)
> > or something similar and use GraphSONMessageSerializerV1d0 serializer to
> > unblock customers who intend to use Graphson-1.0
> >
> >    If there are no objections, I'll proceed with these changes and offer
> a
> > pull request for review. If time permits, I would like to include this
> > change in the upcoming Tinkerpop release(3.7.0?)
> >
> > --
> > Thanks and Regards,
> > Sai Phanindhra
> > Warning: The sender of this message could not be validated and may not be
> > the actual sender.
> >
>
>
> --
> Sai Phanindhra
>