You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/11/21 11:13:47 UTC

[GitHub] [incubator-dolphinscheduler] zhuangchong commented on a change in pull request #4088: [Fix-4090][dao] Add null judgment

zhuangchong commented on a change in pull request #4088:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4088#discussion_r528183521



##########
File path: dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/utils/DagHelper.java
##########
@@ -292,7 +295,6 @@ public static boolean allDependsForbiddenOrEnd(TaskNode taskNode,
      * this function parse the condition node to find the right branch.
      * also check all the depends nodes forbidden or complete
      *
-     * @param preNodeName

Review comment:
       Why remove argument comments from a method？




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org