[GitHub] [tomcat] dao-jun commented on pull request #373: lazy set filed `DELETE_FILES_SERVICE`

[GitBox <gi...@apache.org>]

dao-jun commented on pull request #373:
URL: https://github.com/apache/tomcat/pull/373#issuecomment-720880325


   > How does this fix the issue? It only delays the creation of the executor from the point the class is loaded to the point where the first instance is created. Instance creation is also triggered by the parsing of logging.properties and occurs immediately the class is loaded. The class loading is triggered by the instance creation so I don't see how this proposed PR can help.
   
   Yes, I just noticed it create an instance in `ClassLoaderLogManager#readConfiguration` by invoking `classLoader.loadClass(handlerClassName).getConstructor().newInstance()`, I'm sorry for that.     How about using a single `Thread` instead of `ThreadPoolExecutor` ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org