You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/12/01 02:42:09 UTC
[kudu-CR] [java client] Allow to pass extra flags to tservers/masters
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5299
Change subject: [java client] Allow to pass extra flags to tservers/masters
......................................................................
[java client] Allow to pass extra flags to tservers/masters
This path adds a couple of methods to MiniKuduClusterBuilder so that
a test can pass extra flags to the daemons. Another change is that
the builder is now a protected static final field of BaseKuduTest
so that subclasses can set flags before starting the cluster.
This is required for TestHybridTime to pass for a follow up patch.
Change-Id: If9ecf0d22c0b49e2a07d5e3cf21c762e0790361a
---
M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
2 files changed, 45 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/5299/1
--
To view, visit http://gerrit.cloudera.org:8080/5299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If9ecf0d22c0b49e2a07d5e3cf21c762e0790361a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] [java client] Allow to pass extra flags to tservers/masters
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has uploaded a new patch set (#2).
Change subject: [java client] Allow to pass extra flags to tservers/masters
......................................................................
[java client] Allow to pass extra flags to tservers/masters
This path adds a couple of methods to MiniKuduClusterBuilder so that
a test can pass extra flags to the daemons. Another change is that
the builder is now a protected static final field of BaseKuduTest
so that subclasses can set flags before starting the cluster.
This is required for TestHybridTime to pass for a follow up patch.
Change-Id: If9ecf0d22c0b49e2a07d5e3cf21c762e0790361a
---
M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
2 files changed, 41 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/5299/2
--
To view, visit http://gerrit.cloudera.org:8080/5299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If9ecf0d22c0b49e2a07d5e3cf21c762e0790361a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [java client] Allow to pass extra flags to tservers/masters
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: [java client] Allow to pass extra flags to tservers/masters
......................................................................
[java client] Allow to pass extra flags to tservers/masters
This path adds a couple of methods to MiniKuduClusterBuilder so that
a test can pass extra flags to the daemons. Another change is that
the builder is now a protected static final field of BaseKuduTest
so that subclasses can set flags before starting the cluster.
This is required for TestHybridTime to pass for a follow up patch.
Change-Id: If9ecf0d22c0b49e2a07d5e3cf21c762e0790361a
Reviewed-on: http://gerrit.cloudera.org:8080/5299
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
2 files changed, 41 insertions(+), 3 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9ecf0d22c0b49e2a07d5e3cf21c762e0790361a
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [java client] Allow to pass extra flags to tservers/masters
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [java client] Allow to pass extra flags to tservers/masters
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5299/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java:
Line 220: commandLine.add(extraTserverFlag);
addAll?
Line 299: commandLine.add(extraMasterFlag);
same
--
To view, visit http://gerrit.cloudera.org:8080/5299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9ecf0d22c0b49e2a07d5e3cf21c762e0790361a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [java client] Allow to pass extra flags to tservers/masters
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: [java client] Allow to pass extra flags to tservers/masters
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5299/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java:
Line 220: commandLine.add(extraTserverFlag);
> addAll?
Done
Line 299: commandLine.add(extraMasterFlag);
> same
Done
--
To view, visit http://gerrit.cloudera.org:8080/5299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9ecf0d22c0b49e2a07d5e3cf21c762e0790361a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [java client] Allow to pass extra flags to tservers/masters
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: [java client] Allow to pass extra flags to tservers/masters
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9ecf0d22c0b49e2a07d5e3cf21c762e0790361a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No