You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by "lewismc (via GitHub)" <gi...@apache.org> on 2026/01/12 02:55:26 UTC

[PR] NUTCH-3145 Upgrade to JUnit 6 [nutch]

lewismc opened a new pull request, #883:
URL: https://github.com/apache/nutch/pull/883

   This is a PR for [NUTCH-3145](https://issues.apache.org/jira/browse/NUTCH-3145). It is quite an interesting issue as JUnit 6 requires Java 17. I am not convinced/sure that we want to orchestrate an upgrade from Java 11 --> 17 through a JUnit upgrade. I opened this ticket as a bit of an experiment. It also encouraged me to check in on [NUTCH-2987](https://issues.apache.org/jira/browse/NUTCH-2987) and perhaps more importantly the behemoth that is [HADOOP-17177](https://issues.apache.org/jira/browse/HADOOP-17177).
   Any feedback or thoughts welcome. Thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NUTCH-3145 Upgrade to JUnit 6 [nutch]

Posted by "lewismc (via GitHub)" <gi...@apache.org>.
lewismc merged PR #883:
URL: https://github.com/apache/nutch/pull/883


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NUTCH-3145 Upgrade to JUnit 6 [nutch]

Posted by "sebastian-nagel (via GitHub)" <gi...@apache.org>.
sebastian-nagel commented on PR #883:
URL: https://github.com/apache/nutch/pull/883#issuecomment-3740860855

   I'd be conservative and would not yet force users to require Java 17 as runtime, esp. given that is not yet 100% supported by Hadoop. A backward-compatible approach, similar to that described in [HADOOP-18887](https://issues.apache.org/jira/browse/HADOOP-18887) might be better.
   
   What about?
   - Require Java 17 to build Nutch, resp. run the unit tests.
   - But still allow a Java 11 runtime by setting `javac.version=11`. The binary package would then still run on Java 11.
   
   This option seems to work (I tried it, but without exhaustive testing).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NUTCH-3145 Upgrade to JUnit 6 [nutch]

Posted by "sebastian-nagel (via GitHub)" <gi...@apache.org>.
sebastian-nagel commented on PR #883:
URL: https://github.com/apache/nutch/pull/883#issuecomment-3938867524

   > Resolved conflicts.
   
   Great!
   
   > upgrade to JDK17 BEFORE we consider this branch
   > shared on dev@.
   
   I think it is exhaustively enough discussed the upgrade to JDK 17 on dev@ ([thread](https://lists.apache.org/thread/f9k0l36qwrw35fssgqgkxl0z8jddt91g)) with the consensus to upgrade after the release of 1.22. If we are lucky Hadoop 3.5.0 will be released soon and it should support JDK 17.
   
   > the GitHub CI
   
   I've verified that both GitHub and [Apache Jenkins](https://ci-builds.apache.org/job/Nutch/job/Nutch-trunk/) CI builds use JDK 17, already before merging #825 / NUTCH-3064. GeoIP2 5.0.2 also requires JDK 17 - both build and runtime, the latter only if the plugin is used.
   
   From my perspective: +1 to merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NUTCH-3145 Upgrade to JUnit 6 [nutch]

Posted by "lewismc (via GitHub)" <gi...@apache.org>.
lewismc commented on PR #883:
URL: https://github.com/apache/nutch/pull/883#issuecomment-3741043346

   I augmented the CI to accommodate the backward-compatible Java version strategy for Apache Nutch, similar to the approach described in HADOOP-18887.
   Key principle:
   * Build requirement: Java 17+ (required by JUnit 6)
   * Runtime compatibility: Java 11+ (bytecode target)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NUTCH-3145 Upgrade to JUnit 6 [nutch]

Posted by "lewismc (via GitHub)" <gi...@apache.org>.
lewismc commented on PR #883:
URL: https://github.com/apache/nutch/pull/883#issuecomment-3918379992

   Resolved conflicts. I'm wondering whether we should perform a separaste upgrade to JDK17 **BEFORE** we consider this branch further. It would certainly simpligy the CI as we wouldn't need to worry about the additional complexity it adds to the GitHub CI. I'm open to suggestions and would also like to respect the opinuons shared on dev@. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NUTCH-3145 Upgrade to JUnit 6 [nutch]

Posted by "lewismc (via GitHub)" <gi...@apache.org>.
lewismc commented on PR #883:
URL: https://github.com/apache/nutch/pull/883#issuecomment-3740896436

   Yes I agree with you @sebastian-nagel I'm not keen to force a JDK upgrade to 17 via this PR either. I'll augment the PR accordingly. Thanks for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org