You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Artem Harutyunyan <ar...@mesosphere.io> on 2015/08/06 20:27:32 UTC
Re: Review Request 37190: WIP: Added POST support for /maintenance
endpoint. Performed initial verification of the input.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37190/
-----------------------------------------------------------
(Updated Aug. 6, 2015, 11:27 a.m.)
Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Joseph Wu.
Changes
-------
Addressed some of the comments.
Bugs: MESOS-2067
https://issues.apache.org/jira/browse/MESOS-2067
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3
src/master/maintenance.hpp PRE-CREATION
src/master/maintenance.cpp PRE-CREATION
src/master/master.hpp 30a2550c606ca528ec5b69fc9efedd698d67c5f2
src/master/master.cpp 50b98248463fc4cd48962890c14c7ad64f2b6f43
Diff: https://reviews.apache.org/r/37190/diff/
Testing
-------
Manual testing of the endpoint.
Thanks,
Artem Harutyunyan
Re: Review Request 37190: WIP: Added /maintenance.schedule,
/maintenance.start, /maintenance.stop and /maintenance.status endpoints.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37190/
-----------------------------------------------------------
(Updated Aug. 7, 2015, 1:40 p.m.)
Review request for Benjamin Hindman, Joris Van Remoortere and Joseph Wu.
Changes
-------
Addressed comments; added more endpoints.
Summary (updated)
-----------------
WIP: Added /maintenance.schedule, /maintenance.start, /maintenance.stop and /maintenance.status endpoints.
Bugs: MESOS-2067
https://issues.apache.org/jira/browse/MESOS-2067
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/maintenance/maintenance.proto PRE-CREATION
src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3
src/master/maintenance.hpp PRE-CREATION
src/master/maintenance.cpp PRE-CREATION
src/master/master.hpp 53420ca7d503296fbe11b1ea0795afe2ebf86255
src/master/master.cpp d699e4bc3cf734a516a6baf329919e04744b5702
Diff: https://reviews.apache.org/r/37190/diff/
Testing
-------
Manual testing of the endpoint.
Thanks,
Artem Harutyunyan
Re: Review Request 37190: WIP: Added POST support for /maintenance
endpoint. Performed initial verification of the input.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37190/
-----------------------------------------------------------
(Updated Aug. 7, 2015, 10:05 a.m.)
Review request for Benjamin Hindman, Joris Van Remoortere and Joseph Wu.
Changes
-------
Added maintenance state endpoint. Addressed remaining comment.
Bugs: MESOS-2067
https://issues.apache.org/jira/browse/MESOS-2067
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/maintenance/maintenance.proto PRE-CREATION
src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3
src/master/maintenance.hpp PRE-CREATION
src/master/maintenance.cpp PRE-CREATION
src/master/master.hpp 53420ca7d503296fbe11b1ea0795afe2ebf86255
src/master/master.cpp d699e4bc3cf734a516a6baf329919e04744b5702
Diff: https://reviews.apache.org/r/37190/diff/
Testing
-------
Manual testing of the endpoint.
Thanks,
Artem Harutyunyan
Re: Review Request 37190: WIP: Added POST support for /maintenance
endpoint. Performed initial verification of the input.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37190/
-----------------------------------------------------------
(Updated Aug. 6, 2015, 6:34 p.m.)
Review request for Benjamin Hindman, Joris Van Remoortere and Joseph Wu.
Changes
-------
Uploading WIP.
Bugs: MESOS-2067
https://issues.apache.org/jira/browse/MESOS-2067
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3
src/master/maintenance.hpp PRE-CREATION
src/master/maintenance.cpp PRE-CREATION
src/master/master.hpp 53420ca7d503296fbe11b1ea0795afe2ebf86255
src/master/master.cpp d699e4bc3cf734a516a6baf329919e04744b5702
Diff: https://reviews.apache.org/r/37190/diff/
Testing
-------
Manual testing of the endpoint.
Thanks,
Artem Harutyunyan
Re: Review Request 37190: WIP: Added POST support for /maintenance
endpoint. Performed initial verification of the input.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37190/#review94446
-----------------------------------------------------------
Bad patch!
Reviews applied: [36321, 36571, 37052, 37190]
Failed command: ./support/apply-review.sh -n -r 37190
Error:
2015-08-06 21:16:36 URL:https://reviews.apache.org/r/37190/diff/raw/ [7339/7339] -> "37190.patch" [1]
37190.patch:39: trailing whitespace.
error: patch failed: src/master/maintenance.hpp:32
error: src/master/maintenance.hpp: patch does not apply
error: patch failed: src/master/maintenance.cpp:59
error: src/master/maintenance.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Aug. 6, 2015, 6:27 p.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37190/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2015, 6:27 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-2067
> https://issues.apache.org/jira/browse/MESOS-2067
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3
> src/master/maintenance.hpp PRE-CREATION
> src/master/maintenance.cpp PRE-CREATION
> src/master/master.hpp 30a2550c606ca528ec5b69fc9efedd698d67c5f2
> src/master/master.cpp 50b98248463fc4cd48962890c14c7ad64f2b6f43
>
> Diff: https://reviews.apache.org/r/37190/diff/
>
>
> Testing
> -------
>
> Manual testing of the endpoint.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>