You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mahout.apache.org by sr...@apache.org on 2010/05/08 09:22:33 UTC
svn commit: r942330 - in /lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math: DenseVector.java RandomAccessSparseVector.java SequentialAccessSparseVector.java Vector.java

Author: srowen
Date: Sat May  8 07:22:32 2010
New Revision: 942330

URL: http://svn.apache.org/viewvc?rev=942330&view=rev
Log:
Per Ted's email clarify isDense and isSequentialAccess

Modified:
    lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/DenseVector.java
    lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/RandomAccessSparseVector.java
    lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/SequentialAccessSparseVector.java
    lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/Vector.java

Modified: lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/DenseVector.java
URL: http://svn.apache.org/viewvc/lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/DenseVector.java?rev=942330&r1=942329&r2=942330&view=diff
==============================================================================
--- lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/DenseVector.java (original)
+++ lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/DenseVector.java Sat May  8 07:22:32 2010
@@ -78,10 +78,16 @@ public class DenseVector extends Abstrac
     return new DenseVector(values.clone());
   }
 
+  /**
+   * @return true
+   */
   public boolean isDense() {
     return true;
   }
 
+  /**
+   * @return true
+   */
   public boolean isSequentialAccess() {
     return true;
   }

Modified: lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/RandomAccessSparseVector.java
URL: http://svn.apache.org/viewvc/lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/RandomAccessSparseVector.java?rev=942330&r1=942329&r2=942330&view=diff
==============================================================================
--- lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/RandomAccessSparseVector.java (original)
+++ lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/RandomAccessSparseVector.java Sat May  8 07:22:32 2010
@@ -90,10 +90,16 @@ public class RandomAccessSparseVector ex
     return this;
   }
 
+  /**
+   * @return false
+   */
   public boolean isDense() {
     return false;
   }
 
+  /**
+   * @return false
+   */
   public boolean isSequentialAccess() {
     return false;
   }

Modified: lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/SequentialAccessSparseVector.java
URL: http://svn.apache.org/viewvc/lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/SequentialAccessSparseVector.java?rev=942330&r1=942329&r2=942330&view=diff
==============================================================================
--- lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/SequentialAccessSparseVector.java (original)
+++ lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/SequentialAccessSparseVector.java Sat May  8 07:22:32 2010
@@ -96,10 +96,16 @@ public class SequentialAccessSparseVecto
     return new SequentialAccessSparseVector(size(), values.clone());
   }
 
+  /**
+   * @return false
+   */
   public boolean isDense() {
     return false;
   }
 
+  /**
+   * @return true
+   */
   public boolean isSequentialAccess() {
     return true;
   }

Modified: lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/Vector.java
URL: http://svn.apache.org/viewvc/lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/Vector.java?rev=942330&r1=942329&r2=942330&view=diff
==============================================================================
--- lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/Vector.java (original)
+++ lucene/mahout/trunk/math/src/main/java/org/apache/mahout/math/Vector.java Sat May  8 07:22:32 2010
@@ -93,8 +93,17 @@ public interface Vector extends Cloneabl
    */
   int size();
 
+  /**
+   * @return true iff the {@link Vector} implementation should be considered dense -- that it explicitly
+   *  represents every value
+   */
   boolean isDense();
 
+  /**
+   * @return true iff {@link Vector} should be considered to be iterable in index order in an efficient way.
+   *  In particular this implies that {@link #iterator()} and {@link #iterateNonZero()} return elements
+   *  in ascending order by index.
+   */
   boolean isSequentialAccess();
 
   /**