You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Pinal Shah <pi...@freestoneinfotech.com> on 2021/10/19 07:45:42 UTC
Re: Review Request 73654: ATLAS-4454 : Upgrade JanusGraph version to
0.6.0
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73654/
-----------------------------------------------------------
(Updated Oct. 19, 2021, 7:45 a.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.
Changes
-------
addressed review comments
Bugs: ATLAS-4454
https://issues.apache.org/jira/browse/ATLAS-4454
Repository: atlas
Description
-------
Upgrading janusgraph version - 0.6.0
Upgrading tinkerpop version - 3.5.1
Diffs (updated)
-----
graphdb/janus-hbase2/pom.xml 9ad64062f
graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseKeyColumnValueStore.java 9aa552d4a
graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseStoreManager.java 40bcd1ad3
graphdb/janus/pom.xml f38c4e9a3
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 0d47e38fd
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java 2d5bd8ae7
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java 16fc4451b
graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 81ae202f1
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/BaseUtils.java 82ae67514
pom.xml 84630e76b
repository/src/test/java/org/apache/atlas/query/TraversalComposerTest.java dd56ed141
test-tools/src/main/resources/solr/core-template/solrconfig.xml e7956cb36
tools/atlas-index-repair/pom.xml a723bfa0c
Diff: https://reviews.apache.org/r/73654/diff/3/
Changes: https://reviews.apache.org/r/73654/diff/2-3/
Testing
-------
mvn clean package -Pdist,embedded-hbase-solr - passes
Quick start - passes
Testing by removing janusgraph-cassandra dependency - left
Testing more combination of NEQ, NULL operators - left
Precommit running - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/900
Temporary changes for solrconfig.xml to pass PC
Thanks,
Pinal Shah
Re: Review Request 73654: ATLAS-4454 : Upgrade JanusGraph version to
0.6.0
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73654/#review223633
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Oct. 19, 2021, 4:27 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73654/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2021, 4:27 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4454
> https://issues.apache.org/jira/browse/ATLAS-4454
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Upgrading janusgraph version - 0.6.0
> Upgrading tinkerpop version - 3.5.1
>
>
> Diffs
> -----
>
> graphdb/janus-hbase2/pom.xml 9ad64062f
> graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseKeyColumnValueStore.java 9aa552d4a
> graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseStoreManager.java 40bcd1ad3
> graphdb/janus/pom.xml f38c4e9a3
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 0d47e38fd
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java 2d5bd8ae7
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java 16fc4451b
> graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 81ae202f1
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/BaseUtils.java 82ae67514
> pom.xml 84630e76b
> repository/src/test/java/org/apache/atlas/query/TraversalComposerTest.java dd56ed141
> test-tools/src/main/resources/solr/core-template/solrconfig.xml e7956cb36
> tools/atlas-index-repair/pom.xml a723bfa0c
>
>
> Diff: https://reviews.apache.org/r/73654/diff/3/
>
>
> Testing
> -------
>
> mvn clean package -Pdist,embedded-hbase-solr - passes
> Quick start - passes
>
> Precommit running - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/900
>
>
> Temporary changes for solrconfig.xml to pass PC
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73654: ATLAS-4454 : Upgrade JanusGraph version to
0.6.0
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73654/#review223643
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 20, 2021, 5:45 p.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73654/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2021, 5:45 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4454
> https://issues.apache.org/jira/browse/ATLAS-4454
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Upgrading janusgraph version - 0.6.0
> Upgrading tinkerpop version - 3.5.1
>
>
> Diffs
> -----
>
> graphdb/janus-hbase2/pom.xml 9ad64062f
> graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseKeyColumnValueStore.java 9aa552d4a
> graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseStoreManager.java 40bcd1ad3
> graphdb/janus/pom.xml f38c4e9a3
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 0d47e38fd
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java 2d5bd8ae7
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java 16fc4451b
> graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 81ae202f1
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/BaseUtils.java 82ae67514
> pom.xml 84630e76b
> repository/src/test/java/org/apache/atlas/query/TraversalComposerTest.java dd56ed141
> test-tools/src/main/resources/solr/core-template/solrconfig.xml e7956cb36
> tools/atlas-index-repair/pom.xml a723bfa0c
>
>
> Diff: https://reviews.apache.org/r/73654/diff/4/
>
>
> Testing
> -------
>
> mvn clean package -Pdist,embedded-hbase-solr - passes
> Quick start - passes
>
> Precommit running - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/900
>
>
> Temporary changes for solrconfig.xml to pass PC
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73654: ATLAS-4454 : Upgrade JanusGraph version to
0.6.0
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73654/
-----------------------------------------------------------
(Updated Oct. 20, 2021, 5:45 p.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.
Changes
-------
addressed review comments
Bugs: ATLAS-4454
https://issues.apache.org/jira/browse/ATLAS-4454
Repository: atlas
Description
-------
Upgrading janusgraph version - 0.6.0
Upgrading tinkerpop version - 3.5.1
Diffs (updated)
-----
graphdb/janus-hbase2/pom.xml 9ad64062f
graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseKeyColumnValueStore.java 9aa552d4a
graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseStoreManager.java 40bcd1ad3
graphdb/janus/pom.xml f38c4e9a3
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 0d47e38fd
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java 2d5bd8ae7
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java 16fc4451b
graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 81ae202f1
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/BaseUtils.java 82ae67514
pom.xml 84630e76b
repository/src/test/java/org/apache/atlas/query/TraversalComposerTest.java dd56ed141
test-tools/src/main/resources/solr/core-template/solrconfig.xml e7956cb36
tools/atlas-index-repair/pom.xml a723bfa0c
Diff: https://reviews.apache.org/r/73654/diff/4/
Changes: https://reviews.apache.org/r/73654/diff/3-4/
Testing
-------
mvn clean package -Pdist,embedded-hbase-solr - passes
Quick start - passes
Precommit running - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/900
Temporary changes for solrconfig.xml to pass PC
Thanks,
Pinal Shah
Re: Review Request 73654: ATLAS-4454 : Upgrade JanusGraph version to
0.6.0
Posted by Nixon Rodrigues <ni...@atlan.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73654/#review223630
-----------------------------------------------------------
Ship it!
Ship It!
- Nixon Rodrigues
On Oct. 19, 2021, 11:27 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73654/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2021, 11:27 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4454
> https://issues.apache.org/jira/browse/ATLAS-4454
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Upgrading janusgraph version - 0.6.0
> Upgrading tinkerpop version - 3.5.1
>
>
> Diffs
> -----
>
> graphdb/janus-hbase2/pom.xml 9ad64062f
> graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseKeyColumnValueStore.java 9aa552d4a
> graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseStoreManager.java 40bcd1ad3
> graphdb/janus/pom.xml f38c4e9a3
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 0d47e38fd
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java 2d5bd8ae7
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java 16fc4451b
> graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 81ae202f1
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/BaseUtils.java 82ae67514
> pom.xml 84630e76b
> repository/src/test/java/org/apache/atlas/query/TraversalComposerTest.java dd56ed141
> test-tools/src/main/resources/solr/core-template/solrconfig.xml e7956cb36
> tools/atlas-index-repair/pom.xml a723bfa0c
>
>
> Diff: https://reviews.apache.org/r/73654/diff/3/
>
>
> Testing
> -------
>
> mvn clean package -Pdist,embedded-hbase-solr - passes
> Quick start - passes
>
> Precommit running - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/900
>
>
> Temporary changes for solrconfig.xml to pass PC
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73654: ATLAS-4454 : Upgrade JanusGraph version to
0.6.0
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
> On Oct. 19, 2021, 5:57 p.m., Madhan Neethiraj wrote:
> > graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseKeyColumnValueStore.java
> > Lines 157 (patched)
> > <https://reviews.apache.org/r/73654/diff/3/?file=2254164#file2254164line157>
> >
> > Is there no functional impact in not implemeting this method?
Thanks Madhan for reviewing.
As this method in introduced in interface KeyColumnValueStore, there is a need to override this method.
The implementation (throw new UnsupportedOperationException();) is exactly same as of actual HBaseKeyColumnValueStore class of janusgraph
- Pinal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73654/#review223634
-----------------------------------------------------------
On Oct. 20, 2021, 5:45 p.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73654/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2021, 5:45 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4454
> https://issues.apache.org/jira/browse/ATLAS-4454
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Upgrading janusgraph version - 0.6.0
> Upgrading tinkerpop version - 3.5.1
>
>
> Diffs
> -----
>
> graphdb/janus-hbase2/pom.xml 9ad64062f
> graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseKeyColumnValueStore.java 9aa552d4a
> graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseStoreManager.java 40bcd1ad3
> graphdb/janus/pom.xml f38c4e9a3
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 0d47e38fd
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java 2d5bd8ae7
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java 16fc4451b
> graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 81ae202f1
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/BaseUtils.java 82ae67514
> pom.xml 84630e76b
> repository/src/test/java/org/apache/atlas/query/TraversalComposerTest.java dd56ed141
> test-tools/src/main/resources/solr/core-template/solrconfig.xml e7956cb36
> tools/atlas-index-repair/pom.xml a723bfa0c
>
>
> Diff: https://reviews.apache.org/r/73654/diff/4/
>
>
> Testing
> -------
>
> mvn clean package -Pdist,embedded-hbase-solr - passes
> Quick start - passes
>
> Precommit running - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/900
>
>
> Temporary changes for solrconfig.xml to pass PC
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73654: ATLAS-4454 : Upgrade JanusGraph version to
0.6.0
Posted by Madhan Neethiraj <ma...@apache.org>.
> On Oct. 19, 2021, 5:57 p.m., Madhan Neethiraj wrote:
> > graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseKeyColumnValueStore.java
> > Lines 157 (patched)
> > <https://reviews.apache.org/r/73654/diff/3/?file=2254164#file2254164line157>
> >
> > Is there no functional impact in not implemeting this method?
>
> Pinal Shah wrote:
> Thanks Madhan for reviewing.
> As this method in introduced in interface KeyColumnValueStore, there is a need to override this method.
> The implementation (throw new UnsupportedOperationException();) is exactly same as of actual HBaseKeyColumnValueStore class of janusgraph
Pinal - thanks for the clarification. Patch is good to go!
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73654/#review223634
-----------------------------------------------------------
On Oct. 20, 2021, 5:45 p.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73654/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2021, 5:45 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4454
> https://issues.apache.org/jira/browse/ATLAS-4454
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Upgrading janusgraph version - 0.6.0
> Upgrading tinkerpop version - 3.5.1
>
>
> Diffs
> -----
>
> graphdb/janus-hbase2/pom.xml 9ad64062f
> graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseKeyColumnValueStore.java 9aa552d4a
> graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseStoreManager.java 40bcd1ad3
> graphdb/janus/pom.xml f38c4e9a3
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 0d47e38fd
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java 2d5bd8ae7
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java 16fc4451b
> graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 81ae202f1
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/BaseUtils.java 82ae67514
> pom.xml 84630e76b
> repository/src/test/java/org/apache/atlas/query/TraversalComposerTest.java dd56ed141
> test-tools/src/main/resources/solr/core-template/solrconfig.xml e7956cb36
> tools/atlas-index-repair/pom.xml a723bfa0c
>
>
> Diff: https://reviews.apache.org/r/73654/diff/4/
>
>
> Testing
> -------
>
> mvn clean package -Pdist,embedded-hbase-solr - passes
> Quick start - passes
>
> Precommit running - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/900
>
>
> Temporary changes for solrconfig.xml to pass PC
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73654: ATLAS-4454 : Upgrade JanusGraph version to
0.6.0
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73654/#review223634
-----------------------------------------------------------
graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseKeyColumnValueStore.java
Lines 157 (patched)
<https://reviews.apache.org/r/73654/#comment312749>
Is there no functional impact in not implemeting this method?
graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java
Lines 685 (patched)
<https://reviews.apache.org/r/73654/#comment312747>
query.toString() => query
- to avoid unnecessary cost of creating string
graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java
Lines 687 (patched)
<https://reviews.apache.org/r/73654/#comment312748>
var9 => ex
var10 => ex
- Madhan Neethiraj
On Oct. 19, 2021, 11:27 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73654/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2021, 11:27 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4454
> https://issues.apache.org/jira/browse/ATLAS-4454
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Upgrading janusgraph version - 0.6.0
> Upgrading tinkerpop version - 3.5.1
>
>
> Diffs
> -----
>
> graphdb/janus-hbase2/pom.xml 9ad64062f
> graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseKeyColumnValueStore.java 9aa552d4a
> graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseStoreManager.java 40bcd1ad3
> graphdb/janus/pom.xml f38c4e9a3
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 0d47e38fd
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java 2d5bd8ae7
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java 16fc4451b
> graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 81ae202f1
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/BaseUtils.java 82ae67514
> pom.xml 84630e76b
> repository/src/test/java/org/apache/atlas/query/TraversalComposerTest.java dd56ed141
> test-tools/src/main/resources/solr/core-template/solrconfig.xml e7956cb36
> tools/atlas-index-repair/pom.xml a723bfa0c
>
>
> Diff: https://reviews.apache.org/r/73654/diff/3/
>
>
> Testing
> -------
>
> mvn clean package -Pdist,embedded-hbase-solr - passes
> Quick start - passes
>
> Precommit running - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/900
>
>
> Temporary changes for solrconfig.xml to pass PC
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73654: ATLAS-4454 : Upgrade JanusGraph version to
0.6.0
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73654/
-----------------------------------------------------------
(Updated Oct. 19, 2021, 11:27 a.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath Subramanian.
Bugs: ATLAS-4454
https://issues.apache.org/jira/browse/ATLAS-4454
Repository: atlas
Description
-------
Upgrading janusgraph version - 0.6.0
Upgrading tinkerpop version - 3.5.1
Diffs
-----
graphdb/janus-hbase2/pom.xml 9ad64062f
graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseKeyColumnValueStore.java 9aa552d4a
graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseStoreManager.java 40bcd1ad3
graphdb/janus/pom.xml f38c4e9a3
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 0d47e38fd
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java 2d5bd8ae7
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java 16fc4451b
graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 81ae202f1
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/BaseUtils.java 82ae67514
pom.xml 84630e76b
repository/src/test/java/org/apache/atlas/query/TraversalComposerTest.java dd56ed141
test-tools/src/main/resources/solr/core-template/solrconfig.xml e7956cb36
tools/atlas-index-repair/pom.xml a723bfa0c
Diff: https://reviews.apache.org/r/73654/diff/3/
Testing (updated)
-------
mvn clean package -Pdist,embedded-hbase-solr - passes
Quick start - passes
Precommit running - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/900
Temporary changes for solrconfig.xml to pass PC
Thanks,
Pinal Shah