You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/04/13 12:46:43 UTC
[GitHub] [sling-org-apache-sling-feature-launcher] stbischof opened a new pull request #26: container: adoptopenjdk/openjdk11:alpine-jre
stbischof opened a new pull request #26:
URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/26
switch from slim to jre because it is smalle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] stbischof edited a comment on pull request #26: container: adoptopenjdk/openjdk11:alpine-jre
Posted by GitBox <gi...@apache.org>.
stbischof edited a comment on pull request #26:
URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/26#issuecomment-821587536
Aling starter uses `openjdk:8-jre-alpine` and that is an jre not an jdk
https://github.com/apache/sling-org-apache-sling-starter-docker/blob/0aa71023ee0c862457e7b5879c0e66081cce69a8/Dockerfile#L1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] bdelacretaz commented on pull request #26: container: adoptopenjdk/openjdk11:alpine-jre
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on pull request #26:
URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/26#issuecomment-822266669
> ...Sling starter uses openjdk:8-jre-alpine and that is an jre not an jdk...
Correct, sorry about the noise and +1 for this change then!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] bdelacretaz edited a comment on pull request #26: container: adoptopenjdk/openjdk11:alpine-jre
Posted by GitBox <gi...@apache.org>.
bdelacretaz edited a comment on pull request #26:
URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/26#issuecomment-820989354
Note that the [sling-starter Dockerfiles](https://github.com/apache/sling-org-apache-sling-starter-docker) use a JDK. I vaguely remember a JRE being insufficient in some cases, but don't remember exactly what the issues where. Best might be to ask on our dev list before merging this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on pull request #26: container: adoptopenjdk/openjdk11:alpine-jre
Posted by GitBox <gi...@apache.org>.
stbischof commented on pull request #26:
URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/26#issuecomment-821587536
openjdk:8-jre-alpine is an jre
https://github.com/apache/sling-org-apache-sling-starter-docker/blob/0aa71023ee0c862457e7b5879c0e66081cce69a8/Dockerfile#L1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on pull request #26: container: adoptopenjdk/openjdk11:alpine-jre
Posted by GitBox <gi...@apache.org>.
stbischof commented on pull request #26:
URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/26#issuecomment-822312127
I am happy to get the fast review/response!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] karlpauls merged pull request #26: SLING-10323: use alpine-jre as base image
Posted by GitBox <gi...@apache.org>.
karlpauls merged pull request #26:
URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] bdelacretaz commented on pull request #26: container: adoptopenjdk/openjdk11:alpine-jre
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on pull request #26:
URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/26#issuecomment-820989354
Note that the [sling-starter Dockerfiles](https://github.com/apache/sling-org-apache-sling-starter-docker) use a JDK. I vaguely remember a JRE being insufficient in some cases, but don't remember exactly what the issues where.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] stbischof edited a comment on pull request #26: container: adoptopenjdk/openjdk11:alpine-jre
Posted by GitBox <gi...@apache.org>.
stbischof edited a comment on pull request #26:
URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/26#issuecomment-821587536
Sling starter uses `openjdk:8-jre-alpine` and that is an jre not an jdk
https://github.com/apache/sling-org-apache-sling-starter-docker/blob/0aa71023ee0c862457e7b5879c0e66081cce69a8/Dockerfile#L1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #26: container: adoptopenjdk/openjdk11:alpine-jre
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #26:
URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/26#issuecomment-818708442
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRequest=26&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRequest=26&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRequest=26&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRequest=26&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRequest=26&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRequest=26&resolved=false&types=VULNERABILITY)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher&pullRequest=26&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher&pullRequest=26&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher&pullRequest=26&resolved=false&types=SECURITY_HOTSPOT)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRequest=26&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRequest=26&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRequest=26&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher&pullRequest=26&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher&pullRequest=26&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org