You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by sh...@apache.org on 2019/10/15 08:44:55 UTC

[incubator-echarts] 01/01: test: change recorder key from shift to alt

This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch test-change-record-key
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git

commit 37b23aefcda71e8ac29991f8e61e1f928516ad9e
Author: pissang <bm...@gmail.com>
AuthorDate: Tue Oct 15 16:44:35 2019 +0800

    test: change recorder key from shift to alt
---
 test/runTest/recorder/index.html  | 4 ++--
 test/runTest/recorder/recorder.js | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/test/runTest/recorder/index.html b/test/runTest/recorder/index.html
index c145c58..e0bc594 100644
--- a/test/runTest/recorder/index.html
+++ b/test/runTest/recorder/index.html
@@ -33,8 +33,8 @@ under the License.
             class="recording-button" circle :type="recordingAction ? 'danger' : 'info'"
         >
         </el-button>
-        <div class="hint"><span class="emphasis">SHIFT + R</span>to {{recordingAction ? 'stop' : 'start'}} recording</div>
-        <div class="hint" v-if="recordingAction"><span class="emphasis">SHIFT + S</span>to take screenshot</div>
+        <div class="hint"><span class="emphasis">ALT + R</span>to {{recordingAction ? 'stop' : 'start'}} recording</div>
+        <div class="hint" v-if="recordingAction"><span class="emphasis">ALT + S</span>to take screenshot</div>
         <div class="recording-time" v-if="recordingAction">{{(recordingTimeElapsed / 1000).toFixed(0)}} s</div>
     </div>
     <div id="actions">
diff --git a/test/runTest/recorder/recorder.js b/test/runTest/recorder/recorder.js
index eb89d58..3d4fe62 100644
--- a/test/runTest/recorder/recorder.js
+++ b/test/runTest/recorder/recorder.js
@@ -196,7 +196,7 @@ function notify(title, message) {
 }
 
 function keyboardRecordingHandler(e) {
-    if (e.key.toLowerCase() === 'r' && e.shiftKey) {
+    if (e.keyCode === 82 && e.altKey) {
         let $iframe = getIframe();
         if (!app.recordingAction) {
             // Create a new action if currentAction has ops.
@@ -230,7 +230,7 @@ function keyboardRecordingHandler(e) {
         }
         // Get scroll
     }
-    else if (e.key.toLowerCase() === 's' && e.shiftKey) {
+    else if (e.keyCode === 83 && e.altKey) {
         if (app.recordingAction) {
             app.recordingAction.ops.push({
                 type: 'screenshot',


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org