[GitHub] fmaximus commented on a change in pull request #2705: CLOUDSTACK-10381: Fix password reset / reset ssh key with ConfigDrive

[GitBox <gi...@apache.org>]

fmaximus commented on a change in pull request #2705: CLOUDSTACK-10381: Fix password reset / reset ssh key with ConfigDrive
URL: https://github.com/apache/cloudstack/pull/2705#discussion_r194326251
 
 

 ##########
 File path: server/src/com/cloud/network/element/ConfigDriveNetworkElement.java
 ##########
 @@ -223,7 +231,14 @@ public boolean saveSSHKey(final Network network, final NicProfile nic, final Vir
         if (vm != null && vm.getVirtualMachine().getState().equals(VirtualMachine.State.Running)) {
             throw new CloudRuntimeException("VM should to stopped to reset password");
         }
-        return canHandle(network.getTrafficType());
+
+        final boolean canHandle = canHandle(network.getTrafficType());
+
+        if (canHandle) {
+            storePasswordInVmDetails(vm);
 
 Review comment:
   SaveSshKey implicitly also resets the password. So I'm also saving it in this case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services