You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/10/25 05:12:46 UTC

[GitHub] [incubator-kyuubi] turboFei opened a new pull request #1282: Add KDF stop_engine

turboFei opened a new pull request #1282:
URL: https://github.com/apache/incubator-kyuubi/pull/1282


   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #1282: Add KDF stop_engine

Posted by GitBox <gi...@apache.org>.

turboFei commented on a change in pull request #1282:
URL: https://github.com/apache/incubator-kyuubi/pull/1282#discussion_r736080945



##########
File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/udf/KDFRegistry.scala
##########
@@ -64,6 +67,13 @@ object KDFRegistry {
     "string",
     "1.3.0")
 
+  val stop_engine: KyuubiDefinedFunction = create(

Review comment:
       yes, we can define a `STOP ENGINE` command with kyuubi defined antlr g4.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] wForget commented on a change in pull request #1282: Add KDF stop_engine

Posted by GitBox <gi...@apache.org>.

wForget commented on a change in pull request #1282:
URL: https://github.com/apache/incubator-kyuubi/pull/1282#discussion_r736084028



##########
File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/udf/KDFRegistry.scala
##########
@@ -64,6 +67,13 @@ object KDFRegistry {
     "string",
     "1.3.0")
 
+  val stop_engine: KyuubiDefinedFunction = create(

Review comment:
       > yes, we can define a `STOP ENGINE` command with kyuubi defined antlr g4.
   
   sounds great




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #1282: Add KDF stop_engine

Posted by GitBox <gi...@apache.org>.

turboFei commented on a change in pull request #1282:
URL: https://github.com/apache/incubator-kyuubi/pull/1282#discussion_r735326304



##########
File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/udf/KDFRegistry.scala
##########
@@ -64,6 +67,13 @@ object KDFRegistry {
     "string",
     "1.3.0")
 
+  val stop_engine: KyuubiDefinedFunction = create(

Review comment:
       I detected it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1282: Add KDF stop_engine

Posted by GitBox <gi...@apache.org>.

yaooqinn commented on a change in pull request #1282:
URL: https://github.com/apache/incubator-kyuubi/pull/1282#discussion_r735270738



##########
File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/udf/KDFRegistry.scala
##########
@@ -64,6 +67,13 @@ object KDFRegistry {
     "string",
     "1.3.0")
 
+  val stop_engine: KyuubiDefinedFunction = create(

Review comment:
       what if it is executed only at the executor-side?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] turboFei commented on pull request #1282: Add KDF stop_engine

Posted by GitBox <gi...@apache.org>.

turboFei commented on pull request #1282:
URL: https://github.com/apache/incubator-kyuubi/pull/1282#issuecomment-952669360


   raise another pr for stop engine, it is still in progress
   
   https://github.com/apache/incubator-kyuubi/pull/1301


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] turboFei closed pull request #1282: Add KDF stop_engine

Posted by GitBox <gi...@apache.org>.

turboFei closed pull request #1282:
URL: https://github.com/apache/incubator-kyuubi/pull/1282


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] wForget commented on a change in pull request #1282: Add KDF stop_engine

Posted by GitBox <gi...@apache.org>.

wForget commented on a change in pull request #1282:
URL: https://github.com/apache/incubator-kyuubi/pull/1282#discussion_r735503524



##########
File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/udf/KDFRegistry.scala
##########
@@ -64,6 +67,13 @@ object KDFRegistry {
     "string",
     "1.3.0")
 
+  val stop_engine: KyuubiDefinedFunction = create(

Review comment:
       Like this function, can we intercept and execute it before executing sql through spark, instead of implementing it through udf? We can define a command format and match it through regular.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org