You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/06 05:41:01 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5178: arch/sim: Rename up_vfork[32|64].S to up_vfork_x[32|64].S

xiaoxiang781216 opened a new pull request #5178:
URL: https://github.com/apache/incubator-nuttx/pull/5178


   ## Summary
   to align with up_vfork_arm.S naming style
   
   ## Impact
   No, rename only
   
   ## Testing
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5178: arch/sim: Rename up_vfork[32|64].S to up_vfork_x[32|64].S

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5178:
URL: https://github.com/apache/incubator-nuttx/pull/5178#issuecomment-1007099567


   Yes, the proposal is better, fix here: https://github.com/apache/incubator-nuttx/pull/5188


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on pull request #5178: arch/sim: Rename up_vfork[32|64].S to up_vfork_x[32|64].S

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #5178:
URL: https://github.com/apache/incubator-nuttx/pull/5178#issuecomment-1007029521


   > to align with up_vfork_arm.S naming style
   
   why not `x86` and `x86_64` as we use in other places?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 merged pull request #5178: arch/sim: Rename up_vfork[32|64].S to up_vfork_x[32|64].S

Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #5178:
URL: https://github.com/apache/incubator-nuttx/pull/5178


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org