[jira] [Commented] (FLINK-16283) NullPointerException in GroupAggProcessFunction.close()

["Benchao Li (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045511#comment-17045511 ] 

Benchao Li commented on FLINK-16283:
------------------------------------

[~jark] sorry for the late comment.

I'm curious about when would the `function` be `null`? Do we have somewhere invoking `GroupAggProcessFunction.close()` without `GroupAggProcessFunction.open()` ?

Or the generated function indeed can be null? If that, shouldn't we check for null in the `open` too?

> NullPointerException in GroupAggProcessFunction.close()
> -------------------------------------------------------
>
>                 Key: FLINK-16283
>                 URL: https://issues.apache.org/jira/browse/FLINK-16283
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / Runtime
>    Affects Versions: 1.11.0
>            Reporter: Robert Metzger
>            Assignee: Jark Wu
>            Priority: Major
>              Labels: pull-request-available, test-stability
>             Fix For: 1.11.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> CI run: https://dev.azure.com/rmetzger/Flink/_build/results?buildId=5586&view=logs&j=b1623ac9-0979-5b0d-2e5e-1377d695c991&t=48867695-c47f-5af3-2f21-7845611247b9
> {code}
> java.lang.NullPointerException: null
> 	at org.apache.flink.table.runtime.aggregate.GroupAggProcessFunction.close(GroupAggProcessFunction.scala:182) ~[flink-table_2.11-1.11-SNAPSHOT.jar:1.11-SNAPSHOT]
> 	at org.apache.flink.api.common.functions.util.FunctionUtils.closeFunction(FunctionUtils.java:43) ~[flink-dist_2.11-1.11-SNAPSHOT.jar:1.11-SNAPSHOT]
> 	at org.apache.flink.streaming.api.operators.AbstractUdfStreamOperator.dispose(AbstractUdfStreamOperator.java:117) ~[flink-dist_2.11-1.11-SNAPSHOT.jar:1.11-SNAPSHOT]
> 	at org.apache.flink.streaming.runtime.tasks.StreamTask.disposeAllOperators(StreamTask.java:627) [flink-dist_2.11-1.11-SNAPSHOT.jar:1.11-SNAPSHOT]
> 	at org.apache.flink.streaming.runtime.tasks.StreamTask.cleanUpInvoke(StreamTask.java:565) [flink-dist_2.11-1.11-SNAPSHOT.jar:1.11-SNAPSHOT]
> 	at org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:483) [flink-dist_2.11-1.11-SNAPSHOT.jar:1.11-SNAPSHOT]
> 	at org.apache.flink.runtime.taskmanager.Task.doRun(Task.java:717) [flink-dist_2.11-1.11-SNAPSHOT.jar:1.11-SNAPSHOT]
> 	at org.apache.flink.runtime.taskmanager.Task.run(Task.java:541) [flink-dist_2.11-1.11-SNAPSHOT.jar:1.11-SNAPSHOT]
> 	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242]
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)